[clang][ssaf][NFC] Rename and document makeTU in BuildNamespace

Author: jkorous-apple

clang/include/clang/Analysis/Scalable/Model/BuildNamespace.h

@@ -55,7 +55,11 @@ class BuildNamespace {
   BuildNamespace(BuildNamespaceKind Kind, llvm::StringRef Name)
     : Kind(Kind), Name(Name.str()) {}
 
-  static BuildNamespace makeTU(llvm::StringRef CompilationId);
+  /// Creates a BuildNamespace representing a compilation unit.
+  ///
+  /// \param CompilationId The unique identifier for the compilation unit.
+  /// \returns A BuildNamespace with CompilationUnit kind.
+  static BuildNamespace makeCompilationUnit(llvm::StringRef CompilationId);
 
   bool operator==(const BuildNamespace& Other) const;
   bool operator!=(const BuildNamespace& Other) const;
@@ -88,7 +92,12 @@ class NestedBuildNamespace {
     Namespaces.push_back(N);
   }
 
-  static NestedBuildNamespace makeTU(llvm::StringRef CompilationId);
+  /// Creates a NestedBuildNamespace representing a compilation unit.
+  ///
+  /// \param CompilationId The unique identifier for the compilation unit.
+  /// \returns A NestedBuildNamespace containing a single CompilationUnit
+  ///          BuildNamespace.
+  static NestedBuildNamespace makeCompilationUnit(llvm::StringRef CompilationId);
 
   /// Creates a new NestedBuildNamespace by appending additional namespace.
   ///

clang/lib/Analysis/Scalable/Model/BuildNamespace.cpp

@@ -28,7 +28,7 @@ std::optional<BuildNamespaceKind> parseBuildNamespaceKind(llvm::StringRef Str) {
   return std::nullopt;
 }
 
-BuildNamespace BuildNamespace::makeTU(llvm::StringRef CompilationId) {
+BuildNamespace BuildNamespace::makeCompilationUnit(llvm::StringRef CompilationId) {
   return BuildNamespace{BuildNamespaceKind::CompilationUnit, CompilationId.str()};
 }
 
@@ -44,9 +44,9 @@ bool BuildNamespace::operator<(const BuildNamespace& Other) const {
   return asTuple() < Other.asTuple();
 }
 
-NestedBuildNamespace NestedBuildNamespace::makeTU(llvm::StringRef CompilationId) {
+NestedBuildNamespace NestedBuildNamespace::makeCompilationUnit(llvm::StringRef CompilationId) {
   NestedBuildNamespace Result;
-  Result.Namespaces.push_back(BuildNamespace::makeTU(CompilationId));
+  Result.Namespaces.push_back(BuildNamespace::makeCompilationUnit(CompilationId));
   return Result;
 }
 

clang/unittests/Analysis/Scalable/BuildNamespaceTest.cpp

@@ -13,9 +13,9 @@ namespace clang::ssaf {
 namespace {
 
 TEST(BuildNamespaceTest, Equality) {
-  auto BN1 = BuildNamespace::makeTU("test.cpp");
-  auto BN2 = BuildNamespace::makeTU("test.cpp");
-  auto BN3 = BuildNamespace::makeTU("other.cpp");
+  auto BN1 = BuildNamespace::makeCompilationUnit("test.cpp");
+  auto BN2 = BuildNamespace::makeCompilationUnit("test.cpp");
+  auto BN3 = BuildNamespace::makeCompilationUnit("other.cpp");
 
   EXPECT_EQ(BN1, BN2);
   EXPECT_NE(BN1, BN3);
@@ -54,28 +54,28 @@ TEST(NestedBuildNamespaceTest, DefaultConstruction) {
 }
 
 TEST(NestedBuildNamespaceTest, SingleNamespaceConstruction) {
-  auto BN = BuildNamespace::makeTU("test.cpp");
+  auto BN = BuildNamespace::makeCompilationUnit("test.cpp");
   NestedBuildNamespace NBN(BN);
 
   EXPECT_FALSE(NBN.empty());
 }
 
 TEST(NestedBuildNamespaceTest, MakeTU) {
-  auto NBN = NestedBuildNamespace::makeTU("test.cpp");
+  auto NBN = NestedBuildNamespace::makeCompilationUnit("test.cpp");
   EXPECT_FALSE(NBN.empty());
 }
 
 TEST(NestedBuildNamespaceTest, Equality) {
-  auto NBN1 = NestedBuildNamespace::makeTU("test.cpp");
-  auto NBN2 = NestedBuildNamespace::makeTU("test.cpp");
-  auto NBN3 = NestedBuildNamespace::makeTU("other.cpp");
+  auto NBN1 = NestedBuildNamespace::makeCompilationUnit("test.cpp");
+  auto NBN2 = NestedBuildNamespace::makeCompilationUnit("test.cpp");
+  auto NBN3 = NestedBuildNamespace::makeCompilationUnit("other.cpp");
 
   EXPECT_EQ(NBN1, NBN2);
   EXPECT_NE(NBN1, NBN3);
 }
 
 TEST(NestedBuildNamespaceTest, MakeQualified) {
-  auto NBN1 = NestedBuildNamespace::makeTU("test.cpp");
+  auto NBN1 = NestedBuildNamespace::makeCompilationUnit("test.cpp");
   BuildNamespace LinkNS(BuildNamespaceKind::LinkUnit, "app");
   NestedBuildNamespace NBN2(LinkNS);
 
@@ -87,7 +87,7 @@ TEST(NestedBuildNamespaceTest, MakeQualified) {
 
 TEST(NestedBuildNamespaceTest, EmptyQualified) {
   NestedBuildNamespace Empty;
-  auto NBN = NestedBuildNamespace::makeTU("test.cpp");
+  auto NBN = NestedBuildNamespace::makeCompilationUnit("test.cpp");
 
   auto Qualified = Empty.makeQualified(NBN);
   EXPECT_EQ(Qualified, NBN);

clang/unittests/Analysis/Scalable/EntityNameTest.cpp

@@ -14,8 +14,8 @@ namespace clang::ssaf {
 namespace {
 
 TEST(EntityNameTest, Equality) {
-  auto NBN1 = NestedBuildNamespace::makeTU("test.cpp");
-  auto NBN2 = NestedBuildNamespace::makeTU("test.cpp");
+  auto NBN1 = NestedBuildNamespace::makeCompilationUnit("test.cpp");
+  auto NBN2 = NestedBuildNamespace::makeCompilationUnit("test.cpp");
 
   EntityName EN1("c:@F@foo", "", NBN1);
   EntityName EN2("c:@F@foo", "", NBN2);
@@ -26,7 +26,7 @@ TEST(EntityNameTest, Equality) {
 }
 
 TEST(EntityNameTest, EqualityWithDifferentSuffix) {
-  auto NBN = NestedBuildNamespace::makeTU("test.cpp");
+  auto NBN = NestedBuildNamespace::makeCompilationUnit("test.cpp");
 
   EntityName EN1("c:@F@foo", "1", NBN);
   EntityName EN2("c:@F@foo", "2", NBN);
@@ -35,8 +35,8 @@ TEST(EntityNameTest, EqualityWithDifferentSuffix) {
 }
 
 TEST(EntityNameTest, EqualityWithDifferentNamespace) {
-  auto NBN1 = NestedBuildNamespace::makeTU("test1.cpp");
-  auto NBN2 = NestedBuildNamespace::makeTU("test2.cpp");
+  auto NBN1 = NestedBuildNamespace::makeCompilationUnit("test1.cpp");
+  auto NBN2 = NestedBuildNamespace::makeCompilationUnit("test2.cpp");
 
   EntityName EN1("c:@F@foo", "", NBN1);
   EntityName EN2("c:@F@foo", "", NBN2);
@@ -45,7 +45,7 @@ TEST(EntityNameTest, EqualityWithDifferentNamespace) {
 }
 
 TEST(EntityNameTest, MakeQualified) {
-  auto NBN1 = NestedBuildNamespace::makeTU("test.cpp");
+  auto NBN1 = NestedBuildNamespace::makeCompilationUnit("test.cpp");
   EntityName EN("c:@F@foo", "", NBN1);
 
   BuildNamespace LinkNS(BuildNamespaceKind::LinkUnit, "app");