Skip to content

Commit 141eea2

Browse files
committed
Print all OpMemberDecorate operands.
1 parent 74a3c3b commit 141eea2

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

llvm/lib/Target/SPIRV/MCTargetDesc/SPIRVInstPrinter.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,9 @@ void SPIRVInstPrinter::printInst(const MCInst *MI, uint64_t Address,
142142
printRemainingVariableOps(MI, NumFixedOps, OS, false, true);
143143
break;
144144
}
145+
case SPIRV::OpMemberDecorate:
146+
printRemainingVariableOps(MI, NumFixedOps, OS);
147+
break;
145148
case SPIRV::OpExecutionMode:
146149
case SPIRV::OpExecutionModeId:
147150
case SPIRV::OpLoopMerge: {

llvm/lib/Target/SPIRV/SPIRVInstrInfo.td

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,9 @@ def OpModuleProcessed: Op<330, (outs), (ins StringImm:$process, variable_ops),
127127

128128
def OpDecorate: Op<71, (outs), (ins ANY:$target, Decoration:$dec, variable_ops),
129129
"OpDecorate $target $dec">;
130-
def OpMemberDecorate: Op<72, (outs), (ins TYPE:$t, i32imm:$m, Decoration:$d, variable_ops),
131-
"OpMemberDecorate $t $m $d">;
130+
def OpMemberDecorate
131+
: Op<72, (outs), (ins TYPE:$t, i32imm:$m, Decoration:$d, variable_ops),
132+
"OpMemberDecorate $t $m $d", []>;
132133

133134
// TODO Currently some deprecated opcodes are missing: OpDecorationGroup,
134135
// OpGroupDecorate and OpGroupMemberDecorate

llvm/test/CodeGen/SPIRV/hlsl-resources/StructuredBuffer.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ declare target("spirv.VulkanBuffer", [0 x i32], 12, 1) @llvm.spv.resource.handle
1212
; CHECK: OpDecorate [[BufferVar:%.+]] DescriptorSet 0
1313
; CHECK: OpDecorate [[BufferVar]] Binding 0
1414
; CHECK: OpDecorate [[BufferType:%.+]] Block
15+
; CHECK: OpMemberDecorate [[BufferType]] 0 Offset 0
1516
; CHECK: OpMemberDecorate [[BufferType]] 0 NonWritable
16-
; CHECK-DISABLE: OpMemberDecorate [[RWBufferType]] 0 Offset 0 // The 0 at the end is not output for some reason
1717
; CHECK: OpDecorate [[RWBufferVar:%.+]] DescriptorSet 0
1818
; CHECK: OpDecorate [[RWBufferVar]] Binding 1
1919
; CHECK: OpDecorate [[RWBufferType:%.+]] Block
20-
; CHECK-DISABLE: OpMemberDecorate [[BufferType]] 0 Offset 0 // Same as above
20+
; CHECK: OpMemberDecorate [[RWBufferType]] 0 Offset 0
2121

2222

2323
; CHECK: [[int:%[0-9]+]] = OpTypeInt 32 0

0 commit comments

Comments
 (0)