Skip to content

Commit 14d44e6

Browse files
committed
[libc] matched int types in utimes_test, cleaned up time.yaml
1 parent 39d9932 commit 14d44e6

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

libc/include/sys/time.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ functions:
1010
- name: utimes
1111
return_type: int
1212
arguments:
13-
- type: ptr<const char>
14-
- type: ptr<const struct timeval>
13+
- type: const char*
14+
- type: const struct timeval*

libc/test/src/sys/time/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ add_libc_unittest(
1313
libc.src.sys.time.utimes
1414
libc.src.unistd.close
1515
libc.src.unistd.read
16-
libc.src.unistd.unlink
1716
libc.src.unistd.write
1817
libc.src.stdio.remove
1918
libc.src.sys.stat.stat

libc/test/src/sys/time/utimes_test.cpp

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ constexpr const char *FILE_PATH = "utimes.test";
2424
TEST(LlvmLibcUtimesTest, ChangeTimesSpecific) {
2525
using LIBC_NAMESPACE::testing::ErrnoSetterMatcher::Succeeds;
2626

27-
// const char* FILE_PATH = "testdata/__utimes_changetimes.test";
28-
2927
auto TEST_FILE = libc_make_test_file_path(FILE_PATH);
3028
int fd = LIBC_NAMESPACE::open(TEST_FILE, O_WRONLY | O_CREAT);
3129
ASSERT_GT(fd, 0);
@@ -50,8 +48,10 @@ TEST(LlvmLibcUtimesTest, ChangeTimesSpecific) {
5048
ASSERT_EQ(statbuf.st_mtim.tv_sec, times[1].tv_sec);
5149

5250
// microseconds
53-
ASSERT_EQ(statbuf.st_atim.tv_nsec, times[0].tv_usec * 1000);
54-
ASSERT_EQ(statbuf.st_mtim.tv_nsec, times[1].tv_usec * 1000);
51+
ASSERT_EQ(statbuf.st_atim.tv_nsec,
52+
static_cast<long>(times[0].tv_usec * 1000));
53+
ASSERT_EQ(statbuf.st_mtim.tv_nsec,
54+
static_cast<long>(times[1].tv_usec * 1000));
5555

5656
ASSERT_THAT(LIBC_NAMESPACE::remove(TEST_FILE), Succeeds(0));
5757
}
@@ -62,8 +62,6 @@ TEST(LlvmLibcUtimesTest, InvalidMicroseconds) {
6262
using LIBC_NAMESPACE::testing::ErrnoSetterMatcher::Fails;
6363
using LIBC_NAMESPACE::testing::ErrnoSetterMatcher::Succeeds;
6464

65-
// const char* FILE_PATH = "testdata/__utimes_invalidmicroseconds.test";
66-
6765
auto TEST_FILE = libc_make_test_file_path(FILE_PATH);
6866
int fd = LIBC_NAMESPACE::open(TEST_FILE, O_WRONLY | O_CREAT);
6967
ASSERT_GT(fd, 0);

0 commit comments

Comments
 (0)