removing repeated elem(ElemNum).toAPSInt() calls to top of the loop

Author: sskzakaria

clang/lib/AST/ByteCode/InterpBuiltin.cpp

@@ -3119,43 +3119,30 @@ static bool interp__builtin_cmp_mask(InterpState &S, CodePtr OpPC,
 
     for (unsigned ElemNum = 0; ElemNum < VectorLen; ++ElemNum) {
       INT_TYPE_SWITCH_NO_BOOL(ElemT, {
-        APSInt B = RHS.elem<T>(ElemNum).toAPSInt();
+        const APSInt &A = LHS.elem<T>(ElemNum).toAPSInt();
+        const APSInt &B = RHS.elem<T>(ElemNum).toAPSInt();
         bool Result = false;
         switch (Opcode.getExtValue() & 0x7) {
         case 0x00: // _MM_CMPINT_EQ
-          Result = (LHS.elem<T>(ElemNum).toAPSInt() ==
-                    RHS.elem<T>(ElemNum).toAPSInt());
+          Result = (A == B);
           break;
         case 0x01: // _MM_CMPINT_LT
-          Result = IsUnsigned ? LHS.elem<T>(ElemNum).toAPSInt().ult(
-                                    RHS.elem<T>(ElemNum).toAPSInt())
-                              : LHS.elem<T>(ElemNum).toAPSInt().slt(
-                                    RHS.elem<T>(ElemNum).toAPSInt());
+          Result = IsUnsigned ? A.ult(B) : A.slt(B);
           break;
         case 0x02: // _MM_CMPINT_LE
-          Result = IsUnsigned ? LHS.elem<T>(ElemNum).toAPSInt().ule(
-                                    RHS.elem<T>(ElemNum).toAPSInt())
-                              : LHS.elem<T>(ElemNum).toAPSInt().sle(
-                                    RHS.elem<T>(ElemNum).toAPSInt());
+          Result = IsUnsigned ? A.ule(B) : A.sle(B);
           break;
         case 0x03: // _MM_CMPINT_FALSE
           Result = false;
           break;
         case 0x04: // _MM_CMPINT_NE
-          Result = (LHS.elem<T>(ElemNum).toAPSInt() !=
-                    RHS.elem<T>(ElemNum).toAPSInt());
+          Result = (A != B);
           break;
         case 0x05: // _MM_CMPINT_NLT (>=)
-          Result = IsUnsigned ? LHS.elem<T>(ElemNum).toAPSInt().uge(
-                                    RHS.elem<T>(ElemNum).toAPSInt())
-                              : LHS.elem<T>(ElemNum).toAPSInt().sge(
-                                    RHS.elem<T>(ElemNum).toAPSInt());
+          Result = IsUnsigned ? A.uge(B) : A.sge(B);
           break;
         case 0x06: // _MM_CMPINT_NLE (>)
-          Result = IsUnsigned ? LHS.elem<T>(ElemNum).toAPSInt().ugt(
-                                    RHS.elem<T>(ElemNum).toAPSInt())
-                              : LHS.elem<T>(ElemNum).toAPSInt().sgt(
-                                    RHS.elem<T>(ElemNum).toAPSInt());
+          Result = IsUnsigned ? A.ugt(B) : A.sgt(B);
           break;
         case 0x07: // _MM_CMPINT_TRUE
           Result = true;

clang/lib/AST/ExprConstant.cpp

@@ -15497,8 +15497,8 @@ bool IntExprEvaluator::VisitBuiltinCallExpr(const CallExpr *E,
 
     APSInt RetMask(llvm::APInt(RetWidth, 0), /*isUnsigned=*/true);
     for (unsigned ElemNum = 0; ElemNum < VectorLen; ++ElemNum) {
-      APSInt A = LHS.getVectorElt(ElemNum).getInt();
-      APSInt B = RHS.getVectorElt(ElemNum).getInt();
+      const APSInt &A = LHS.getVectorElt(ElemNum).getInt();
+      const APSInt &B = RHS.getVectorElt(ElemNum).getInt();
       bool result = false;
 
       switch (Opcode.getExtValue() & 0x7) {
@@ -15531,7 +15531,6 @@ bool IntExprEvaluator::VisitBuiltinCallExpr(const CallExpr *E,
       RetMask.setBitVal(ElemNum, Mask[ElemNum] && result);
     }
 
-    RetMask.setIsUnsigned(true);
     return Success(APValue(RetMask), E);
   }
   }