addressing inbelic comments

joaosaffran · joaosaffran · commit 159cd5793e9b · 2025-09-24T12:37:02.000-07:00
diff --git a/llvm/lib/ObjectYAML/DXContainerYAML.cpp b/llvm/lib/ObjectYAML/DXContainerYAML.cpp
@@ -212,7 +212,7 @@ DXContainerYAML::RootSignatureYamlDesc::create(
     if (Version > 2) {
 #define STATIC_SAMPLER_FLAG(Num, Enum, Flag)                                   \
   NewS.Enum =                                                                  \
-      (S.Flags & llvm::to_underlying(dxbc::StaticSamplerFlags::Enum)) > 0;
+      (S.Flags & llvm::to_underlying(dxbc::StaticSamplerFlags::Enum));
 #include "llvm/BinaryFormat/DXContainerConstants.def"
     }
     RootSigDesc.StaticSamplers.push_back(NewS);
diff --git a/llvm/unittests/Object/DXContainerTest.cpp b/llvm/unittests/Object/DXContainerTest.cpp
@@ -1201,6 +1201,9 @@ TEST(RootSignature, ParseStaticSamplers) {
     ASSERT_EQ(Sampler.ShaderVisibility, 7u);
   }
   {
+    // this is testing static sampler parsing for root signature version 1.2, 
+    // it changes: the version number, the size of root signature being emitted 
+    // and the values for flag fields.
     uint8_t Buffer[] = {
         0x44, 0x58, 0x42, 0x43, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
         0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ DXContainerYAML::RootSignatureYamlDesc::create(`
`212`	`212`	`if (Version > 2) {`
`213`	`213`	`#define STATIC_SAMPLER_FLAG(Num, Enum, Flag) \`
`214`	`214`	`NewS.Enum = \`
`215`		`- (S.Flags & llvm::to_underlying(dxbc::StaticSamplerFlags::Enum)) > 0;`
	`215`	`+ (S.Flags & llvm::to_underlying(dxbc::StaticSamplerFlags::Enum));`
`216`	`216`	`#include "llvm/BinaryFormat/DXContainerConstants.def"`
`217`	`217`	`}`
`218`	`218`	`RootSigDesc.StaticSamplers.push_back(NewS);`
Original file line number	Diff line number	Diff line change
`@@ -1201,6 +1201,9 @@ TEST(RootSignature, ParseStaticSamplers) {`
`1201`	`1201`	`ASSERT_EQ(Sampler.ShaderVisibility, 7u);`
`1202`	`1202`	`}`
`1203`	`1203`	`{`
	`1204`	`+ // this is testing static sampler parsing for root signature version 1.2,`
	`1205`	`+ // it changes: the version number, the size of root signature being emitted`
	`1206`	`+ // and the values for flag fields.`
`1204`	`1207`	`uint8_t Buffer[] = {`
`1205`	`1208`	`0x44, 0x58, 0x42, 0x43, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,`
`1206`	`1209`	`0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,`