Fix cleanup in Type.h.

Add tests for multi-dimensional and variable-length arrays.

Author: Doug Wyatt

clang/include/clang/AST/Type.h

@@ -8838,14 +8838,12 @@ void FixedPointValueToString(SmallVectorImpl<char> &Str, llvm::APSInt Val,
 inline FunctionEffectsRef FunctionEffectsRef::get(QualType QT) {
   const Type *TypePtr = QT.getTypePtr();
   while (true) {
-    if (QualType Pointee = TypePtr->getPointeeType())
+    if (QualType Pointee = TypePtr->getPointeeType(); !Pointee.isNull())
       TypePtr = Pointee.getTypePtr();
     else if (TypePtr->isArrayType())
       TypePtr = TypePtr->getBaseElementTypeUnsafe();
     else
       break;
-    }
-    TypePtr = Pointee.getTypePtr();
   }
   if (const auto *FPT = TypePtr->getAs<FunctionProtoType>())
     return FPT->getFunctionEffects();

clang/test/Sema/attr-nonblocking-constraints.cpp

@@ -255,6 +255,15 @@ void nb14(unsigned idx) [[clang::nonblocking]]
 
 	FPArray src{ nb, nullptr };
 	FP f = src[idx]; // This should not generate a warning.
+
+	FP twoDim[2][2] = {};
+	FP g = twoDim[1][1];
+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wvla-extension"
+	FP vla[idx];
+#pragma clang diagnostic pop
+	FP h = vla[0];
 }
 
 // Block variables