Windows shared library currently not supported

Author: Meinersbur

flang-rt/CMakeLists.txt

@@ -190,6 +190,12 @@ set(CMAKE_CXX_STANDARD_REQUIRED YES)
 configure_file(cmake/config.h.cmake.in config.h)
 
 
+# The bootstrap build will create a phony target with the same as the top-level
+# directory ("flang-rt") and delegate it to the runtimes build dir.
+# AddFlangRT will add all non-EXCLUDE_FROM_ALL targets to it.
+add_custom_target(flang-rt)
+
+
 ###################
 # Build Artifacts #
 ###################

flang-rt/cmake/modules/AddFlangRT.cmake

@@ -51,7 +51,7 @@ function (add_flangrt_library name)
   if (ARG_OBJECT)
     list(APPEND extra_args OBJECT)
   endif ()
-  if (EXCLUDE_FROM_ALL)
+  if (ARG_EXCLUDE_FROM_ALL)
     list(APPEND extra_args EXCLUDE_FROM_ALL)
   endif ()
 
@@ -130,4 +130,10 @@ function (add_flangrt_library name)
         RUNTIME DESTINATION "${FLANGRT_INSTALL_LIB_DIR}"
       )
   endif ()
+
+  # flang-rt should build all the flang-rt targets that are built in an
+  # 'all' build.
+  if (NOT ARG_EXCLUDE_FROM_ALL)
+    add_dependencies(flang-rt ${name})
+  endif ()
 endfunction (add_flangrt_library)

flang-rt/lib/flang_rt/CMakeLists.txt

@@ -130,6 +130,10 @@ if (NOT WIN32)
   add_library(flang_rt.static ALIAS flang_rt)
   add_library(flang_rt.unittest ALIAS flang_rt)
 else()
+  # Target for building all versions of the runtime
+  add_custom_target(flang_rt)
+  set_target_properties(flang_rt PROPERTIES FOLDER "Fortran Runtime/Meta")
+
   function (add_win_flangrt_library libtype suffix msvc_lib)
     set(name "flang_rt.${suffix}")
     add_flangrt_library(${name} ${libtype}
@@ -149,6 +153,7 @@ else()
 
     enable_cuda_compilation(${name} "${supported_sources}")
     enable_omp_offload_compilation(${name} "${supported_sources}")
+    add_dependencies(flang_rt ${name})
   endfunction ()
 
   add_win_flangrt_library(STATIC static     MultiThreaded)
@@ -157,18 +162,19 @@ else()
   # unittests link against LLVMSupport which is compiled with /MD
   add_win_flangrt_library(STATIC unittest   MultiThreadedDLL EXCLUDE_FROM_ALL)
 
-  # FIXME: Before DLL versions of the runtime can be used, exported definitions
-  # must be annotated with __declspec(dllexport).
-  add_win_flangrt_library(SHARED dynamic     MultiThreadedDLL)
-  add_win_flangrt_library(SHARED dynamic_dbg MultiThreadedDebugDLL)
-
-  # Target for building all versions of the runtime
-  add_custom_target(flang_rt)
-  set_target_properties(flang_rt PROPERTIES FOLDER "Fortran Runtime/Meta")
-  add_dependencies(flang_rt
-      flang_rt.static
-      flang_rt.static_dbg
-      flang_rt.dynamic
-      flang_rt.dynamic_dbg
-    )
+  # FIXME: Generating runtime DLLs is currently not possible. There are two
+  # roadblocks:
+  #
+  #  * Flang emits /DEFAULTLIB:flang_rt.dynamic.lib into
+  #    iso_fortran_env_impl.f90.obj. Since that file is itself part of
+  #    flang_rt.dynamic, this results in a recursive dependency when invoking
+  #    the linker.
+  #
+  #  * The externally-visible functions must either by annotated with
+  #    __declspec(dllexport), or listed in a exports file. A possible workaround
+  #    is CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS which would also export the internal
+  #    C++ symbols.
+  #
+  #add_win_flangrt_library(SHARED dynamic     MultiThreadedDLL)
+  #add_win_flangrt_library(SHARED dynamic_dbg MultiThreadedDebugDLL)
 endif()

flang-rt/test/CMakeLists.txt

@@ -44,18 +44,20 @@ endif ()
 set(FLANGRT_TEST_DEPENDS
     FlangRTUnitTests
     flang_rt.unittest
+    flang_rt.static
   )
 
 add_custom_target(flang-rt-test-depends)
 set_target_properties(flang-rt-test-depends PROPERTIES FOLDER "Fortran Runtime/Meta")
 add_dependencies(flang-rt-test-depends ${FLANGRT_TEST_DEPENDS})
 
 add_lit_testsuite(check-flang-rt "Running the flang-rt regression tests"
-  ${CMAKE_CURRENT_BINARY_DIR}
-  DEPENDS ${FLANGRT_TEST_DEPENDS}
-)
+    ${CMAKE_CURRENT_BINARY_DIR}
+    DEPENDS flang-rt-test-depends
+  )
 set_target_properties(check-flang-rt PROPERTIES FOLDER "Fortran Runtime/Meta")
 
 
 add_lit_testsuites(flang-rt ${CMAKE_CURRENT_SOURCE_DIR}
-  DEPENDS ${FLANGRT_TEST_DEPENDS})
+    DEPENDS flang-rt-test-depends
+  )