add TODO

charles-zablit · charles-zablit · commit 1715c0e43535 · 2025-06-25T19:07:35.000+01:00
diff --git a/lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp b/lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
@@ -1142,6 +1142,9 @@ void PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
         }
       }
 
+      // TODO: The result of this loop is almost equivalent to deriving the SDK
+      // from the target triple, which would be a lot cheaper.
+
       if (FileSystem::Instance().Exists(merged_sdk.GetSysroot())) {
         sysroot_spec = merged_sdk.GetSysroot();
       } else {

Original file line number	Diff line number	Diff line change
`@@ -1142,6 +1142,9 @@ void PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(`
`1142`	`1142`	`}`
`1143`	`1143`	`}`
`1144`	`1144`
	`1145`	`+ // TODO: The result of this loop is almost equivalent to deriving the SDK`
	`1146`	`+ // from the target triple, which would be a lot cheaper.`
	`1147`	`+`
`1145`	`1148`	`if (FileSystem::Instance().Exists(merged_sdk.GetSysroot())) {`
`1146`	`1149`	`sysroot_spec = merged_sdk.GetSysroot();`
`1147`	`1150`	`} else {`