Skip to content

Commit 178168e

Browse files
jrbyrnesdtcxzyw
andauthored
Apply suggestions from code review
Co-authored-by: Yingwei Zheng <[email protected]>
1 parent 691d72d commit 178168e

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3662,17 +3662,15 @@ Instruction *InstCombinerImpl::visitOr(BinaryOperator &I) {
36623662

36633663
if (LHSDecompose && RHSDecompose && LHSDecompose->X == RHSDecompose->X &&
36643664
(ICmpInst::isEquality(LHSDecompose->Pred)) &&
3665-
!RHSDecompose->Mask.isNegative() &&
3666-
!LHSDecompose->Mask.isNegative() && RHSDecompose->Mask.isPowerOf2() &&
3665+
RHSDecompose->Mask.isPowerOf2() &&
36673666
LHSDecompose->Mask.isPowerOf2() &&
3668-
LHSDecompose->Mask != RHSDecompose->Mask &&
3669-
LHSDecompose->C.isZero() && RHSDecompose->C.isZero()) {
3667+
LHSDecompose->Mask != RHSDecompose->Mask) {
36703668
if (LHSDecompose->Pred == ICmpInst::ICMP_NE)
36713669
std::swap(Op0Eq, Op0Ne);
36723670
if (RHSDecompose->Pred == ICmpInst::ICMP_NE)
36733671
std::swap(Op1Eq, Op1Ne);
36743672

3675-
if (Op0Ne->isStrictlyPositive() && Op1Ne->isStrictlyPositive() &&
3673+
if (!Op0Ne->isZero() && !Op1Ne->isZero() &&
36763674
Op0Eq->isZero() && Op1Eq->isZero() &&
36773675
Op0Ne->urem(LHSDecompose->Mask).isZero() &&
36783676
Op1Ne->urem(RHSDecompose->Mask).isZero() &&

0 commit comments

Comments
 (0)