[MC][ELF] Have an assert catching creating group sections without signatures. (#113553)

kosarev · web-flow · commit 183ddefff60f · 2024-10-25T13:06:32.000+01:00
diff --git a/llvm/include/llvm/MC/MCSectionELF.h b/llvm/include/llvm/MC/MCSectionELF.h
@@ -62,6 +62,8 @@ class MCSectionELF final : public MCSection {
                   type == ELF::SHT_NOBITS, Begin),
         Type(type), Flags(flags), UniqueID(UniqueID), EntrySize(entrySize),
         Group(group, IsComdat), LinkedToSym(LinkedToSym) {
+    assert((!(Flags & ELF::SHF_GROUP) || Group.getPointer()) &&
+           "Group section without signature!");
     if (Group.getPointer())
       Group.getPointer()->setIsSignature();
   }

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,8 @@ class MCSectionELF final : public MCSection {`
`62`	`62`	`type == ELF::SHT_NOBITS, Begin),`
`63`	`63`	`Type(type), Flags(flags), UniqueID(UniqueID), EntrySize(entrySize),`
`64`	`64`	`Group(group, IsComdat), LinkedToSym(LinkedToSym) {`
	`65`	`+ assert((!(Flags & ELF::SHF_GROUP) \|\| Group.getPointer()) &&`
	`66`	`+ "Group section without signature!");`
`65`	`67`	`if (Group.getPointer())`
`66`	`68`	`Group.getPointer()->setIsSignature();`
`67`	`69`	`}`