Fix bug with the test helper method

Author: Jlalond

lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidumpYaml.py

@@ -7,7 +7,6 @@
 from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 from lldbsuite.test import lldbutil
-from dataclass import dataclass
 
 
 class AddressRange:
@@ -19,6 +18,8 @@ def __init__(self, begin, end):
         self.end = end
 
 
+# We skip all these tests on Windows because on Windows Minidumps
+# are not generated by LLDB.
 class ProcessSaveCoreMinidumpTestCaseYaml(TestBase):
     def process_from_yaml(self, yaml_file):
         minidump_path = self.getBuildArtifact(os.path.basename(yaml_file) + ".dmp")
@@ -27,6 +28,7 @@ def process_from_yaml(self, yaml_file):
         self.process = self.target.LoadCore(minidump_path)
         return self.process
 
+    @skipIfWindows
     def validate_regions_saved_correctly(
         self, core_process, expected_region, expected_invalid_region=None
     ):
@@ -52,11 +54,12 @@ def validate_regions_saved_correctly(
         # Validate we can't read the original_region
         core_process.ReadMemory(
             expected_invalid_region.begin,
-            expected_invalid_region.end - expected_invalid_region.end,
+            expected_invalid_region.end - expected_invalid_region.begin,
             error,
         )
-        self.assertTrue(error.Success(), error.GetCString())
+        self.assertTrue(error.Fail(), error.GetCString())
 
+    @skipIfWindows
     def test_saving_sub_memory_range(self):
         """
         Validate we can save a Minidump for a subsection of a memory range.
@@ -89,6 +92,7 @@ def test_saving_sub_memory_range(self):
             core_process, expected_address_range, expected_invalid_range
         )
 
+    @skipIfWindows
     def test_saving_super_memory_range(self):
         """
         Validate we can save a Minidump for a subsection of a memory range.
@@ -121,6 +125,7 @@ def test_saving_super_memory_range(self):
             core_process, expected_address_range, expected_invalid_range
         )
 
+    @skipIfWindows
     def test_region_that_goes_out_of_bounds(self):
         """
         Validate we can save a Minidump for a custom region
@@ -151,6 +156,7 @@ def test_region_that_goes_out_of_bounds(self):
             core_process, expected_address_range, expected_invalid_range
         )
 
+    @skipIfWindows
     def test_region_that_starts_out_of_bounds(self):
         """
         Validate we can save a Minidump for a custom region
@@ -181,6 +187,7 @@ def test_region_that_starts_out_of_bounds(self):
             core_process, expected_address_range, expected_invalid_range
         )
 
+    @skipIfWindows
     def test_region_spans_multiple_regions(self):
         """
         Validate we can save a Minidump for a custom region
@@ -208,6 +215,7 @@ def test_region_spans_multiple_regions(self):
         expected_address_range = AddressRange(begin, end)
         self.validate_regions_saved_correctly(core_process, expected_address_range)
 
+    @skipIfWindows
     def test_region_spans_multiple_regions_with_one_subrange(self):
         """
         Validate we can save a Minidump for a custom region