[flang] Add missing argument to pause_code test and clean up PAUSE lowering

Author: sathvikreddy853

flang/lib/Lower/Runtime.cpp

@@ -264,7 +264,7 @@ void Fortran::lower::genSyncTeamStatement(
 void Fortran::lower::genPauseStatement(
     Fortran::lower::AbstractConverter &converter,
     const Fortran::parser::PauseStmt &stmt) {
-  
+
   fir::FirOpBuilder &builder = converter.getFirOpBuilder();
   mlir::Location loc = converter.getCurrentLocation();
   Fortran::lower::StatementContext stmtCtx;
@@ -275,38 +275,39 @@ void Fortran::lower::genPauseStatement(
 
   if (stmt.v.has_value()) {
     const auto &code = stmt.v.value();
-    auto expr = converter.genExprValue(*Fortran::semantics::GetExpr(code), stmtCtx);
+    auto expr =
+        converter.genExprValue(*Fortran::semantics::GetExpr(code), stmtCtx);
     expr.match(
         // Character-valued expression -> call PauseStatementText (CHAR, LEN)
         [&](const fir::CharBoxValue &x) {
-          callee = fir::runtime::getRuntimeFunc<mkRTKey(PauseStatementText)>(loc, builder);
+          callee = fir::runtime::getRuntimeFunc<mkRTKey(PauseStatementText)>(
+              loc, builder);
           calleeType = callee.getFunctionType();
 
           operands.push_back(
               builder.createConvert(loc, calleeType.getInput(0), x.getAddr()));
           operands.push_back(
               builder.createConvert(loc, calleeType.getInput(1), x.getLen()));
         },
-        // Numeric/unboxed value -> call PauseStatement which accepts an integer code.
+        // Unboxed value -> call PauseStatementInt which accepts an integer.
         [&](fir::UnboxedValue x) {
-           callee = fir::runtime::getRuntimeFunc<mkRTKey(PauseStatementInt)>(loc, builder);
-           calleeType = callee.getFunctionType();
-            if (calleeType.getNumInputs() >= 1) {
-              mlir::Value cast =
-                builder.createConvert(loc, calleeType.getInput(0), x);
-            operands.push_back(cast);
-            }
+          callee = fir::runtime::getRuntimeFunc<mkRTKey(PauseStatementInt)>(
+              loc, builder);
+          calleeType = callee.getFunctionType();
+          assert(calleeType.getNumInputs() >= 1);
+          mlir::Value cast =
+              builder.createConvert(loc, calleeType.getInput(0), x);
+          operands.push_back(cast);
         },
         [&](auto) {
           fir::emitFatalError(loc, "unhandled expression in PAUSE");
-          // mlir::emitError(loc, "unhandled expression in PAUSE");
-          std::exit(1);
         });
   } else {
-    callee = fir::runtime::getRuntimeFunc<mkRTKey(PauseStatement)>(loc, builder);
+    callee =
+        fir::runtime::getRuntimeFunc<mkRTKey(PauseStatement)>(loc, builder);
     calleeType = callee.getFunctionType();
   }
-  
+
   fir::CallOp::create(builder, loc, callee, operands);
 
   // NOTE: PAUSE does not terminate the current block. The program may resume

flang/test/Lower/pause-statement.f90

@@ -1,22 +1,23 @@
-! RUN: bbc %s -emit-fir --canonicalize -o - | FileCheck %s
+! RUN: bbc %s -emit-fir -hlfir=false --canonicalize -o - | FileCheck %s
 
 ! CHECK-LABEL: pause_test
 subroutine pause_test()
+  pause
   ! CHECK: fir.call @_Fortran{{.*}}PauseStatement()
   ! CHECK-NEXT: return
-  pause
 end subroutine
 
 ! CHECK-LABEL: pause_code
 subroutine pause_code()
   pause 42
- ! CHECK: fir.call @_Fortran{{.*}}PauseStatementInt
- ! CHECK-NEXT: return
+  ! CHECK: %[[c42:.*]] = arith.constant 42 : i32
+  ! CHECK: fir.call @_Fortran{{.*}}PauseStatementInt(%[[c42]])
+  ! CHECK-NEXT: return
 end subroutine
 
 ! CHECK-LABEL: pause_msg
 subroutine pause_msg()
-  pause "hello"
+  pause 'hello'
   ! CHECK-DAG: %[[five:.*]] = arith.constant 5 : index
   ! CHECK-DAG: %[[lit:.*]] = fir.address_of(@_QQ{{.*}}) : !fir.ref<!fir.char<1,5>>
   ! CHECK-DAG: %[[buff:.*]] = fir.convert %[[lit]] : (!fir.ref<!fir.char<1,5>>) -> !fir.ref<i8>
@@ -26,4 +27,5 @@ subroutine pause_msg()
 end subroutine
 
 ! CHECK-DAG: func private @_Fortran{{.*}}PauseStatement
+! CHECK-DAG: func private @_Fortran{{.*}}PauseStatementInt
 ! CHECK-DAG: func private @_Fortran{{.*}}PauseStatementText