Fix clang-tidy issues the right way

Author: ldionne

libcxx/include/ccomplex

@@ -26,13 +26,11 @@
 #if _LIBCPP_STD_VER >= 20
 
 using __standard_header_ccomplex _LIBCPP_DEPRECATED_("removed in C++20. Include <complex> instead.") = void;
-// NOLINTNEXTLINE(clang-diagnostic-deprecated-declarations)
 using __use_standard_header_ccomplex = __standard_header_ccomplex;
 
 #elif _LIBCPP_STD_VER >= 17
 
 using __standard_header_ccomplex _LIBCPP_DEPRECATED_("Include <complex> instead.") = void;
-// NOLINTNEXTLINE(clang-diagnostic-deprecated-declarations)
 using __use_standard_header_ccomplex = __standard_header_ccomplex;
 
 #endif

libcxx/include/ciso646

@@ -24,7 +24,6 @@
 #if _LIBCPP_STD_VER >= 20
 
 using __standard_header_ciso646 _LIBCPP_DEPRECATED_("removed in C++20. Include <version> instead.") = void;
-// NOLINTNEXTLINE(clang-diagnostic-deprecated-declarations)
 using __use_standard_header_ciso646 = __standard_header_ciso646;
 
 #endif

libcxx/include/cstdalign

@@ -43,13 +43,11 @@ Macros:
 #if _LIBCPP_STD_VER >= 20
 
 using __standard_header_cstdalign _LIBCPP_DEPRECATED_("removed in C++20.") = void;
-// NOLINTNEXTLINE(clang-diagnostic-deprecated-declarations)
 using __use_standard_header_cstdalign = __standard_header_cstdalign;
 
 #elif _LIBCPP_STD_VER >= 17
 
 using __standard_header_cstdalign _LIBCPP_DEPRECATED = void;
-// NOLINTNEXTLINE(clang-diagnostic-deprecated-declarations)
 using __use_standard_header_cstdalign = __standard_header_cstdalign;
 
 #endif

libcxx/include/cstdbool

@@ -31,13 +31,11 @@ Macros:
 #if _LIBCPP_STD_VER >= 20
 
 using __standard_header_cstdbool _LIBCPP_DEPRECATED_("removed in C++20.") = void;
-// NOLINTNEXTLINE(clang-diagnostic-deprecated-declarations)
 using __use_standard_header_cstdbool = __standard_header_cstdbool;
 
 #elif _LIBCPP_STD_VER >= 17
 
 using __standard_header_cstdbool _LIBCPP_DEPRECATED = void;
-// NOLINTNEXTLINE(clang-diagnostic-deprecated-declarations)
 using __use_standard_header_cstdbool = __standard_header_cstdbool;
 
 #endif

libcxx/include/ctgmath

@@ -28,13 +28,11 @@
 #if _LIBCPP_STD_VER >= 20
 
 using __standard_header_ctgmath _LIBCPP_DEPRECATED_("removed in C++20. Include <cmath> and <complex> instead.") = void;
-// NOLINTNEXTLINE(clang-diagnostic-deprecated-declarations)
 using __use_standard_header_ctgmath = __standard_header_ctgmath;
 
 #elif _LIBCPP_STD_VER >= 17
 
 using __standard_header_ctgmath _LIBCPP_DEPRECATED_("Include <cmath> and <complex> instead.") = void;
-// NOLINTNEXTLINE(clang-diagnostic-deprecated-declarations)
 using __use_standard_header_ctgmath = __standard_header_ctgmath;
 
 #endif

libcxx/test/libcxx/clang_tidy.gen.py

@@ -15,7 +15,7 @@
 
 import sys
 sys.path.append(sys.argv[1])
-from libcxx.header_information import lit_header_restrictions, public_headers
+from libcxx.header_information import lit_header_restrictions, lit_header_undeprecations, public_headers
 
 for header in public_headers:
   print(f"""\
@@ -30,6 +30,7 @@
 // UNSUPPORTED: clang-17
 
 {lit_header_restrictions.get(header, '')}
+{lit_header_undeprecations.get(header, '')}
 
 // TODO: run clang-tidy with modules enabled once they are supported
 // RUN: %{{clang-tidy}} %s --warnings-as-errors=* -header-filter=.* --checks='-*,libcpp-*' --load=%{{test-tools-dir}}/clang_tidy_checks/libcxx-tidy.plugin -- %{{compile_flags}} -fno-modules