fix incorrect null terminator check

uzairnawaz · uzairnawaz · commit 194b8e0f89cc · 2025-08-05T20:49:09.000Z
diff --git a/libc/src/__support/wchar/string_converter.h b/libc/src/__support/wchar/string_converter.h
@@ -78,7 +78,7 @@ template <typename T> class StringConverter {
     }
 
     ErrorOr<CharType> out = cr.pop<CharType>();
-    if (out.has_value() && out.value() == L'\0')
+    if (out.has_value() && out.value() == 0) // if out isn't null terminator or an error
       src_len = src_idx;
 
     num_to_write--;

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ template <typename T> class StringConverter {`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`ErrorOr<CharType> out = cr.pop<CharType>();`
`81`		`- if (out.has_value() && out.value() == L'\0')`
	`81`	`+ if (out.has_value() && out.value() == 0) // if out isn't null terminator or an error`
`82`	`82`	`src_len = src_idx;`
`83`	`83`
`84`	`84`	`num_to_write--;`