Skip to content

Commit 19900bb

Browse files
kovdan01kovdan01
committed
Address review comments
1 parent 2a97034 commit 19900bb

File tree

1 file changed

+37
-37
lines changed

1 file changed

+37
-37
lines changed

‎llvm/test/MC/AArch64/arm64-elf-relocs.s‎

Lines changed: 37 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -35,75 +35,63 @@
3535
// CHECK: add x5, x0, :tlsdesc_lo12:sym
3636
// CHECK-OBJ-LP64: 1c R_AARCH64_TLSDESC_ADD_LO12 sym
3737

38-
add x5, x0, #:tlsdesc_auth_lo12:sym
39-
// CHECK: add x5, x0, :tlsdesc_auth_lo12:sym
40-
// CHECK-OBJ-LP64: 20 R_AARCH64_AUTH_TLSDESC_ADD_LO12 sym
41-
4238
add x0, x2, #:lo12:sym+8
4339
// CHECK: add x0, x2, :lo12:sym
44-
// CHECK-OBJ-LP64: 24 R_AARCH64_ADD_ABS_LO12_NC sym+0x8
40+
// CHECK-OBJ-LP64: 20 R_AARCH64_ADD_ABS_LO12_NC sym+0x8
4541

4642
add x5, x7, #:dtprel_lo12:sym+1
4743
// CHECK: add x5, x7, :dtprel_lo12:sym+1
48-
// CHECK-OBJ-LP64: 28 R_AARCH64_TLSLD_ADD_DTPREL_LO12 sym+0x1
44+
// CHECK-OBJ-LP64: 24 R_AARCH64_TLSLD_ADD_DTPREL_LO12 sym+0x1
4945

5046
add x9, x12, #:dtprel_lo12_nc:sym+2
5147
// CHECK: add x9, x12, :dtprel_lo12_nc:sym+2
52-
// CHECK-OBJ-LP64: 2c R_AARCH64_TLSLD_ADD_DTPREL_LO12_NC sym+0x2
48+
// CHECK-OBJ-LP64: 28 R_AARCH64_TLSLD_ADD_DTPREL_LO12_NC sym+0x2
5349

5450
add x20, x30, #:tprel_lo12:sym+12
5551
// CHECK: add x20, x30, :tprel_lo12:sym+12
56-
// CHECK-OBJ-LP64: 30 R_AARCH64_TLSLE_ADD_TPREL_LO12 sym+0xc
52+
// CHECK-OBJ-LP64: 2c R_AARCH64_TLSLE_ADD_TPREL_LO12 sym+0xc
5753

5854
add x9, x12, #:tprel_lo12_nc:sym+54
5955
// CHECK: add x9, x12, :tprel_lo12_nc:sym+54
60-
// CHECK-OBJ-LP64: 34 R_AARCH64_TLSLE_ADD_TPREL_LO12_NC sym+0x36
56+
// CHECK-OBJ-LP64: 30 R_AARCH64_TLSLE_ADD_TPREL_LO12_NC sym+0x36
6157

6258
add x5, x0, #:tlsdesc_lo12:sym+70
6359
// CHECK: add x5, x0, :tlsdesc_lo12:sym+70
64-
// CHECK-OBJ-LP64: 38 R_AARCH64_TLSDESC_ADD_LO12 sym+0x46
65-
66-
add x5, x0, #:tlsdesc_auth_lo12:sym+70
67-
// CHECK: add x5, x0, :tlsdesc_auth_lo12:sym+70
68-
// CHECK-OBJ-LP64: 3c R_AARCH64_AUTH_TLSDESC_ADD_LO12 sym+0x46
60+
// CHECK-OBJ-LP64: 34 R_AARCH64_TLSDESC_ADD_LO12 sym+0x46
6961

7062
.hword sym + 4 - .
71-
// CHECK-OBJ-LP64: 40 R_AARCH64_PREL16 sym+0x4
63+
// CHECK-OBJ-LP64: 38 R_AARCH64_PREL16 sym+0x4
7264
.word sym - . + 8
73-
// CHECK-OBJ-LP64: 42 R_AARCH64_PREL32 sym+0x8
65+
// CHECK-OBJ-LP64: 3a R_AARCH64_PREL32 sym+0x8
7466
.xword sym-.
75-
// CHECK-OBJ-LP64: 46 R_AARCH64_PREL64 sym{{$}}
67+
// CHECK-OBJ-LP64: 3e R_AARCH64_PREL64 sym{{$}}
7668

7769
.hword sym
78-
// CHECK-OBJ-LP64: 4e R_AARCH64_ABS16 sym
70+
// CHECK-OBJ-LP64: 46 R_AARCH64_ABS16 sym
7971
.word sym+1
80-
// CHECK-OBJ-LP64: 50 R_AARCH64_ABS32 sym+0x1
72+
// CHECK-OBJ-LP64: 48 R_AARCH64_ABS32 sym+0x1
8173
.xword sym+16
82-
// CHECK-OBJ-LP64: 54 R_AARCH64_ABS64 sym+0x10
74+
// CHECK-OBJ-LP64: 4c R_AARCH64_ABS64 sym+0x10
8375

8476
adrp x0, sym
8577
// CHECK: adrp x0, sym
86-
// CHECK-OBJ-LP64: 5c R_AARCH64_ADR_PREL_PG_HI21 sym
78+
// CHECK-OBJ-LP64: 54 R_AARCH64_ADR_PREL_PG_HI21 sym
8779

8880
adrp x15, :got:sym
8981
// CHECK: adrp x15, :got:sym
90-
// CHECK-OBJ-LP64: 60 R_AARCH64_ADR_GOT_PAGE sym
82+
// CHECK-OBJ-LP64: 58 R_AARCH64_ADR_GOT_PAGE sym
9183

9284
adrp x15, :got_auth:sym
9385
// CHECK: adrp x15, :got_auth:sym
94-
// CHECK-OBJ-LP64: 64 R_AARCH64_AUTH_ADR_GOT_PAGE sym
86+
// CHECK-OBJ-LP64: 5c R_AARCH64_AUTH_ADR_GOT_PAGE sym
9587

9688
adrp x29, :gottprel:sym
9789
// CHECK: adrp x29, :gottprel:sym
98-
// CHECK-OBJ-LP64: 68 R_AARCH64_TLSIE_ADR_GOTTPREL_PAGE21 sym
90+
// CHECK-OBJ-LP64: 60 R_AARCH64_TLSIE_ADR_GOTTPREL_PAGE21 sym
9991

10092
adrp x2, :tlsdesc:sym
10193
// CHECK: adrp x2, :tlsdesc:sym
102-
// CHECK-OBJ-LP64: 6c R_AARCH64_TLSDESC_ADR_PAGE21 sym
103-
104-
adrp x2, :tlsdesc_auth:sym
105-
// CHECK: adrp x2, :tlsdesc_auth:sym
106-
// CHECK-OBJ-LP64: 70 R_AARCH64_AUTH_TLSDESC_ADR_PAGE21 sym
94+
// CHECK-OBJ-LP64: 64 R_AARCH64_TLSDESC_ADR_PAGE21 sym
10795

10896
// LLVM is not competent enough to do this relocation because the
10997
// page boundary could occur anywhere after linking. A relocation
@@ -112,7 +100,7 @@
112100
.global trickQuestion
113101
trickQuestion:
114102
// CHECK: adrp x3, trickQuestion
115-
// CHECK-OBJ-LP64: 74 R_AARCH64_ADR_PREL_PG_HI21 trickQuestion
103+
// CHECK-OBJ-LP64: 68 R_AARCH64_ADR_PREL_PG_HI21 trickQuestion
116104

117105
ldrb w2, [x3, :lo12:sym]
118106
ldrsb w5, [x7, #:lo12:sym]
@@ -323,13 +311,6 @@ trickQuestion:
323311
// CHECK-OBJ-LP64: R_AARCH64_TLSDESC_LD64_LO12 sym
324312
// CHECK-OBJ-LP64: R_AARCH64_TLSDESC_LD64_LO12 sym
325313

326-
ldr x24, [x23, #:tlsdesc_auth_lo12:sym]
327-
ldr d22, [x21, :tlsdesc_auth_lo12:sym]
328-
// CHECK: ldr x24, [x23, :tlsdesc_auth_lo12:sym]
329-
// CHECK: ldr d22, [x21, :tlsdesc_auth_lo12:sym]
330-
// CHECK-OBJ-LP64: R_AARCH64_AUTH_TLSDESC_LD64_LO12 sym
331-
// CHECK-OBJ-LP64: R_AARCH64_AUTH_TLSDESC_LD64_LO12 sym
332-
333314
ldr q20, [x19, #:lo12:sym]
334315
// CHECK: ldr q20, [x19, :lo12:sym]
335316
// CHECK-OBJ-LP64: R_AARCH64_LDST128_ABS_LO12_NC sym
@@ -378,6 +359,25 @@ trickQuestion:
378359
// CHECK-OBJ-LP64-NEXT: R_AARCH64_LD64_GOTPAGE_LO15 local2{{$}}
379360
// CHECK-OBJ-LP64-NEXT: R_AARCH64_ADR_GOT_PAGE local3{{$}}
380361

362+
add x5, x0, #:tlsdesc_auth_lo12:sym
363+
// CHECK: add x5, x0, :tlsdesc_auth_lo12:sym
364+
// CHECK-OBJ-LP64: R_AARCH64_AUTH_TLSDESC_ADD_LO12 sym
365+
366+
add x5, x0, #:tlsdesc_auth_lo12:sym+70
367+
// CHECK: add x5, x0, :tlsdesc_auth_lo12:sym+70
368+
// CHECK-OBJ-LP64: R_AARCH64_AUTH_TLSDESC_ADD_LO12 sym+0x46
369+
370+
adrp x2, :tlsdesc_auth:sym
371+
// CHECK: adrp x2, :tlsdesc_auth:sym
372+
// CHECK-OBJ-LP64: R_AARCH64_AUTH_TLSDESC_ADR_PAGE21 sym
373+
374+
ldr x24, [x23, #:tlsdesc_auth_lo12:sym]
375+
ldr d22, [x21, :tlsdesc_auth_lo12:sym]
376+
// CHECK: ldr x24, [x23, :tlsdesc_auth_lo12:sym]
377+
// CHECK: ldr d22, [x21, :tlsdesc_auth_lo12:sym]
378+
// CHECK-OBJ-LP64: R_AARCH64_AUTH_TLSDESC_LD64_LO12 sym
379+
// CHECK-OBJ-LP64: R_AARCH64_AUTH_TLSDESC_LD64_LO12 sym
380+
381381
.data
382382
local0: .long 0
383383
local1: .long 0

0 commit comments

Comments
 (0)