Skip to content

Commit 199c0cb

Browse files
author
joaosaffran
committed
removing shifts from values in dxcontainer related to root signature
1 parent 35a2e0b commit 199c0cb

File tree

2 files changed

+19
-17
lines changed

2 files changed

+19
-17
lines changed

llvm/include/llvm/BinaryFormat/DXContainer.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,12 +154,12 @@ enum class FeatureFlags : uint64_t {
154154
static_assert((uint64_t)FeatureFlags::NextUnusedBit <= 1ull << 63,
155155
"Shader flag bits exceed enum size.");
156156

157-
#define ROOT_ELEMENT_FLAG(Num, Val) Val = 1ull << Num,
157+
#define ROOT_ELEMENT_FLAG(Num, Val) Val = Num,
158158
enum class RootElementFlag : uint32_t {
159159
#include "DXContainerConstants.def"
160160
};
161161

162-
#define ROOT_DESCRIPTOR_FLAG(Num, Val) Val = 1ull << Num,
162+
#define ROOT_DESCRIPTOR_FLAG(Num, Val) Val = Num,
163163
enum class RootDescriptorFlag : uint32_t {
164164
#include "DXContainerConstants.def"
165165
};

llvm/include/llvm/BinaryFormat/DXContainerConstants.def

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -59,28 +59,30 @@ SHADER_FEATURE_FLAG(33, 39, NextUnusedBit, "Next reserved shader flag bit (not a
5959
// ROOT_ELEMENT_FLAG(bit offset for the flag, name).
6060
#ifdef ROOT_ELEMENT_FLAG
6161

62-
ROOT_ELEMENT_FLAG(0, AllowInputAssemblerInputLayout)
63-
ROOT_ELEMENT_FLAG(1, DenyVertexShaderRootAccess)
64-
ROOT_ELEMENT_FLAG(2, DenyHullShaderRootAccess)
65-
ROOT_ELEMENT_FLAG(3, DenyDomainShaderRootAccess)
66-
ROOT_ELEMENT_FLAG(4, DenyGeometryShaderRootAccess)
67-
ROOT_ELEMENT_FLAG(5, DenyPixelShaderRootAccess)
68-
ROOT_ELEMENT_FLAG(6, AllowStreamOutput)
69-
ROOT_ELEMENT_FLAG(7, LocalRootSignature)
70-
ROOT_ELEMENT_FLAG(8, DenyAmplificationShaderRootAccess)
71-
ROOT_ELEMENT_FLAG(9, DenyMeshShaderRootAccess)
72-
ROOT_ELEMENT_FLAG(10, CBVSRVUAVHeapDirectlyIndexed)
73-
ROOT_ELEMENT_FLAG(11, SamplerHeapDirectlyIndexed)
62+
ROOT_ELEMENT_FLAG(0, NONE)
63+
ROOT_ELEMENT_FLAG(0x1, AllowInputAssemblerInputLayout)
64+
ROOT_ELEMENT_FLAG(0x2, DenyVertexShaderRootAccess)
65+
ROOT_ELEMENT_FLAG(0x4, DenyHullShaderRootAccess)
66+
ROOT_ELEMENT_FLAG(0x8, DenyDomainShaderRootAccess)
67+
ROOT_ELEMENT_FLAG(0x10, DenyGeometryShaderRootAccess)
68+
ROOT_ELEMENT_FLAG(0x20, DenyPixelShaderRootAccess)
69+
ROOT_ELEMENT_FLAG(0x40, AllowStreamOutput)
70+
ROOT_ELEMENT_FLAG(0x80, LocalRootSignature)
71+
ROOT_ELEMENT_FLAG(0x100, DenyAmplificationShaderRootAccess)
72+
ROOT_ELEMENT_FLAG(0x200, DenyMeshShaderRootAccess)
73+
ROOT_ELEMENT_FLAG(0x400, CBVSRVUAVHeapDirectlyIndexed)
74+
ROOT_ELEMENT_FLAG(0x800, SamplerHeapDirectlyIndexed)
7475
#undef ROOT_ELEMENT_FLAG
7576
#endif // ROOT_ELEMENT_FLAG
7677

7778

7879
// ROOT_DESCRIPTOR_FLAG(bit offset for the flag, name).
7980
#ifdef ROOT_DESCRIPTOR_FLAG
8081

81-
ROOT_DESCRIPTOR_FLAG(1, DATA_VOLATILE)
82-
ROOT_DESCRIPTOR_FLAG(2, DATA_STATIC_WHILE_SET_AT_EXECUTE)
83-
ROOT_DESCRIPTOR_FLAG(3, DATA_STATIC)
82+
ROOT_DESCRIPTOR_FLAG(0, NONE)
83+
ROOT_DESCRIPTOR_FLAG(0x2, DATA_VOLATILE)
84+
ROOT_DESCRIPTOR_FLAG(0x4, DATA_STATIC_WHILE_SET_AT_EXECUTE)
85+
ROOT_DESCRIPTOR_FLAG(0x8, DATA_STATIC)
8486
#undef ROOT_DESCRIPTOR_FLAG
8587
#endif // ROOT_DESCRIPTOR_FLAG
8688

0 commit comments

Comments
 (0)