Skip to content

Commit 19fae2c

Browse files
author
Kamil Kashapov
committed
fixup! Change IRB.getInt32Ty() to MS.IntptrTy, fix the tests
1 parent 87be1b8 commit 19fae2c

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6655,13 +6655,12 @@ struct VarArgPowerPC32Helper : public VarArgHelperBase {
66556655
for (CallInst *OrigInst : VAStartInstrumentationList) {
66566656
NextNodeIRBuilder IRB(OrigInst);
66576657
Value *VAListTag = OrigInst->getArgOperand(0);
6658-
Value *RegSaveAreaPtrPtr =
6659-
IRB.CreatePtrToInt(VAListTag, MS.IntptrTy);
6658+
Value *RegSaveAreaPtrPtr = IRB.CreatePtrToInt(VAListTag, MS.IntptrTy);
66606659
Value *RegSaveAreaSize = CopySize;
66616660

66626661
// In PPC32 va_list_tag is a struct
6663-
RegSaveAreaPtrPtr = IRB.CreateAdd(RegSaveAreaPtrPtr,
6664-
ConstantInt::get(MS.IntptrTy, 8));
6662+
RegSaveAreaPtrPtr =
6663+
IRB.CreateAdd(RegSaveAreaPtrPtr, ConstantInt::get(MS.IntptrTy, 8));
66656664

66666665
// On PPC 32 reg_save_area can only hold 32 bytes of data
66676666
RegSaveAreaSize = IRB.CreateBinaryIntrinsic(
@@ -6684,8 +6683,8 @@ struct VarArgPowerPC32Helper : public VarArgHelperBase {
66846683

66856684
RegSaveAreaShadowPtr =
66866685
IRB.CreatePtrToInt(RegSaveAreaShadowPtr, MS.IntptrTy);
6687-
Value *FPSaveArea = IRB.CreateAdd(
6688-
RegSaveAreaShadowPtr, ConstantInt::get(MS.IntptrTy, 32));
6686+
Value *FPSaveArea = IRB.CreateAdd(RegSaveAreaShadowPtr,
6687+
ConstantInt::get(MS.IntptrTy, 32));
66896688
FPSaveArea = IRB.CreateIntToPtr(FPSaveArea, MS.PtrTy);
66906689
// We fill fp shadow with zeroes as uninitialized fp args should have
66916690
// been found during call base check
@@ -6697,10 +6696,9 @@ struct VarArgPowerPC32Helper : public VarArgHelperBase {
66976696
// RegSaveAreaSize is min(CopySize, 32) -> no overflow can occur
66986697
Value *OverflowAreaSize = IRB.CreateSub(CopySize, RegSaveAreaSize);
66996698

6700-
Value *OverflowAreaPtrPtr =
6701-
IRB.CreatePtrToInt(VAListTag, MS.IntptrTy);
6702-
OverflowAreaPtrPtr = IRB.CreateAdd(
6703-
OverflowAreaPtrPtr, ConstantInt::get(MS.IntptrTy, 4));
6699+
Value *OverflowAreaPtrPtr = IRB.CreatePtrToInt(VAListTag, MS.IntptrTy);
6700+
OverflowAreaPtrPtr =
6701+
IRB.CreateAdd(OverflowAreaPtrPtr, ConstantInt::get(MS.IntptrTy, 4));
67046702
OverflowAreaPtrPtr = IRB.CreateIntToPtr(OverflowAreaPtrPtr, MS.PtrTy);
67056703

67066704
Value *OverflowAreaPtr = IRB.CreateLoad(MS.PtrTy, OverflowAreaPtrPtr);

0 commit comments

Comments
 (0)