Skip to content

Commit 1a4fa79

Browse files
committed
review: use empty instead of 0 < size check
1 parent 763d4cf commit 1a4fa79

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

llvm/lib/Frontend/HLSL/HLSLRootSignature.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ static raw_ostream &printFlags(raw_ostream &OS, const T Value,
2929
OS << " | ";
3030

3131
StringRef MaybeFlag = enumToStringRef(T(Bit), Flags);
32-
if (0 < MaybeFlag.size())
32+
if (!MaybeFlag.empty())
3333
OS << MaybeFlag;
3434
else
3535
OS << "invalid: " << Bit;

llvm/lib/Frontend/HLSL/RootSignatureMetadata.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ MDNode *MetadataBuilder::BuildRootDescriptor(const RootDescriptor &Descriptor) {
129129
StringRef ResName =
130130
enumToStringRef(dxil::ResourceClass(to_underlying(Descriptor.Type)),
131131
ArrayRef(ResourceClassNames));
132-
assert(0 < ResName.size() && "Provided an invalid Resource Class");
132+
assert(!ResName.empty() && "Provided an invalid Resource Class");
133133
SmallString<7> Name({"Root", ResName});
134134
Metadata *Operands[] = {
135135
MDString::get(Ctx, Name),
@@ -171,7 +171,7 @@ MDNode *MetadataBuilder::BuildDescriptorTableClause(
171171
StringRef ResName =
172172
enumToStringRef(dxil::ResourceClass(to_underlying(Clause.Type)),
173173
ArrayRef(ResourceClassNames));
174-
assert(0 < ResName.size() && "Provided an invalid Resource Class");
174+
assert(!ResName.empty() && "Provided an invalid Resource Class");
175175
Metadata *Operands[] = {
176176
MDString::get(Ctx, ResName),
177177
ConstantAsMetadata::get(Builder.getInt32(Clause.NumDescriptors)),

0 commit comments

Comments
 (0)