Skip to content

Commit 1a68ecf

Browse files
committed
Make bool operator explicit
1 parent 3ce76bc commit 1a68ecf

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

mlir/include/mlir/Dialect/Vector/IR/VectorOps.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ struct AlignmentBytes {
8282
uint64_t alignment = 0;
8383
AlignmentBytes() = default;
8484
explicit AlignmentBytes(uint64_t alignment) : alignment(alignment) {};
85-
operator bool() const { return 0 != alignment; }
85+
explicit operator bool() const { return alignment; }
86+
uint64_t getAlignment() const { return alignment; }
8687
};
8788

8889
BroadcastableToResult

mlir/include/mlir/Dialect/Vector/IR/VectorOps.td

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1731,7 +1731,7 @@ def Vector_LoadOp : Vector_Op<"load", [
17311731
CArg<"bool", "false">:$nontemporal,
17321732
CArg<"AlignmentBytes", "AlignmentBytes()">: $alignment), [{
17331733
return build($_builder, $_state, resultType, base, indices, nontemporal,
1734-
alignment != 0 ? $_builder.getI64IntegerAttr(alignment) :
1734+
alignment ? $_builder.getI64IntegerAttr(alignment.getAlignment()) :
17351735
nullptr);
17361736
}]>,
17371737
OpBuilder<(ins "TypeRange":$resultTypes,
@@ -1740,7 +1740,7 @@ def Vector_LoadOp : Vector_Op<"load", [
17401740
CArg<"bool", "false">:$nontemporal,
17411741
CArg<"AlignmentBytes", "AlignmentBytes()">: $alignment), [{
17421742
return build($_builder, $_state, resultTypes, base, indices, nontemporal,
1743-
alignment != 0 ? $_builder.getI64IntegerAttr(alignment) :
1743+
alignment ? $_builder.getI64IntegerAttr(alignment.getAlignment()) :
17441744
nullptr);
17451745
}]>
17461746
];
@@ -1849,7 +1849,7 @@ def Vector_StoreOp : Vector_Op<"store", [
18491849
CArg<"bool", "false">:$nontemporal,
18501850
CArg<"AlignmentBytes", "AlignmentBytes()">:$alignment), [{
18511851
return build($_builder, $_state, valueToStore, base, indices, nontemporal,
1852-
alignment != 0 ? $_builder.getI64IntegerAttr(alignment) :
1852+
alignment ? $_builder.getI64IntegerAttr(alignment.getAlignment()) :
18531853
nullptr);
18541854
}]>
18551855
];

0 commit comments

Comments
 (0)