[llvm-remarkutil] Simplify code with std::map::operator[] (NFC) (#111407)

kazutakahirata · web-flow · commit 1ad3180b4a07 · 2024-10-07T21:46:41.000-07:00
diff --git a/llvm/tools/llvm-remarkutil/RemarkCounter.cpp b/llvm/tools/llvm-remarkutil/RemarkCounter.cpp
@@ -198,12 +198,8 @@ void ArgumentCounter::collect(const Remark &Remark) {
 }
 
 void RemarkCounter::collect(const Remark &Remark) {
-  std::optional<std::string> Key = getGroupByKey(Remark);
-  if (!Key.has_value())
-    return;
-  auto Iter = CountedByRemarksMap.insert({*Key, 1});
-  if (!Iter.second)
-    Iter.first->second += 1;
+  if (std::optional<std::string> Key = getGroupByKey(Remark))
+    ++CountedByRemarksMap[*Key];
 }
 
 Error ArgumentCounter::print(StringRef OutputFileName) {

Original file line number	Diff line number	Diff line change
`@@ -198,12 +198,8 @@ void ArgumentCounter::collect(const Remark &Remark) {`
`198`	`198`	`}`
`199`	`199`
`200`	`200`	`void RemarkCounter::collect(const Remark &Remark) {`
`201`		`- std::optional<std::string> Key = getGroupByKey(Remark);`
`202`		`- if (!Key.has_value())`
`203`		`- return;`
`204`		`- auto Iter = CountedByRemarksMap.insert({*Key, 1});`
`205`		`- if (!Iter.second)`
`206`		`- Iter.first->second += 1;`
	`201`	`+ if (std::optional<std::string> Key = getGroupByKey(Remark))`
	`202`	`+ ++CountedByRemarksMap[*Key];`
`207`	`203`	`}`
`208`	`204`
`209`	`205`	`Error ArgumentCounter::print(StringRef OutputFileName) {`