Merge branch 'main' into andre/tighten-warnings-api

Author: akuhlens

llvm/lib/CodeGen/MachineOutliner.cpp

@@ -1017,9 +1017,6 @@ MachineFunction *MachineOutliner::createOutlinedFunction(
         /* Outlined code is optimized code by definition. */
         DISubprogram::SPFlagDefinition | DISubprogram::SPFlagOptimized);
 
-    // Don't add any new variables to the subprogram.
-    DB.finalizeSubprogram(OutlinedSP);
-
     // Attach subprogram to the function.
     F->setSubprogram(OutlinedSP);
     // We're done with the DIBuilder.

llvm/lib/Transforms/IPO/IROutliner.cpp

@@ -686,9 +686,6 @@ Function *IROutliner::createFunction(Module &M, OutlinableGroup &Group,
         /* Outlined code is optimized code by definition. */
         DISubprogram::SPFlagDefinition | DISubprogram::SPFlagOptimized);
 
-    // Don't add any new variables to the subprogram.
-    DB.finalizeSubprogram(OutlinedSP);
-
     // Attach subprogram to the function.
     F->setSubprogram(OutlinedSP);
     // We're done with the DIBuilder.

llvm/lib/Transforms/Utils/Debugify.cpp

@@ -254,7 +254,6 @@ bool llvm::applyDebugifyMetadata(
     }
     if (ApplyToMF)
       ApplyToMF(DIB, F);
-    DIB.finalizeSubprogram(SP);
   }
   DIB.finalize();
 

mlir/lib/ExecutionEngine/VulkanRuntime.cpp

@@ -20,7 +20,7 @@
 #include <iomanip>
 #include <iostream>
 
-inline void emitVulkanError(const char *api, VkResult error) {
+static inline void emitVulkanError(const char *api, VkResult error) {
   std::cerr << " failed with error code " << error << " when executing " << api;
 }
 

mlir/lib/Query/Matcher/VariantValue.cpp

@@ -35,7 +35,7 @@ class VariantMatcher::VariadicOpPayload : public VariantMatcher::Payload {
 
   std::optional<DynMatcher> getDynMatcher() const override {
     std::vector<DynMatcher> dynMatchers;
-    for (auto variantMatcher : args) {
+    for (const auto &variantMatcher : args) {
       std::optional<DynMatcher> dynMatcher = variantMatcher.getDynMatcher();
       if (dynMatcher)
         dynMatchers.push_back(dynMatcher.value());