Addresses PR reviews

Author: badumbatish

llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp

@@ -3409,30 +3409,18 @@ combineVectorSizedSetCCEquality(SDNode *N, TargetLowering::DAGCombinerInfo &DCI,
   if (!IsVectorBitCastCheap(X) || !IsVectorBitCastCheap(Y))
     return SDValue();
 
-  // TODO: Not sure what's the purpose of this? I'm keeping here since RISCV has
-  // it
-  if (DCI.DAG.getMachineFunction().getFunction().hasFnAttribute(
-          Attribute::NoImplicitFloat))
-    return SDValue();
-
-  unsigned OpSize = OpVT.getSizeInBits();
-  unsigned VecSize = OpSize / 8;
-
-  EVT VecVT = EVT::getVectorVT(*DCI.DAG.getContext(), MVT::i8, VecSize);
-  EVT CmpVT = EVT::getVectorVT(*DCI.DAG.getContext(), MVT::i8, VecSize);
+  EVT VecVT = MVT::v16i8;
 
   SDValue VecX = DAG.getBitcast(VecVT, X);
   SDValue VecY = DAG.getBitcast(VecVT, Y);
 
-  SDValue Cmp = DAG.getSetCC(DL, CmpVT, VecX, VecY, CC);
+  SDValue Cmp = DAG.getSetCC(DL, VecVT, VecX, VecY, CC);
 
-  SDValue AllTrue = DAG.getZExtOrTrunc(
-      DAG.getNode(
-          ISD::INTRINSIC_WO_CHAIN, DL, MVT::i32,
-          {DAG.getConstant(Intrinsic::wasm_alltrue, DL, MVT::i32), Cmp}),
-      DL, MVT::i1);
+  SDValue AllTrue = DAG.getNode(
+      ISD::INTRINSIC_WO_CHAIN, DL, MVT::i32,
+      {DAG.getConstant(Intrinsic::wasm_alltrue, DL, MVT::i32), Cmp});
 
-  return DAG.getSetCC(DL, VT, AllTrue, DAG.getConstant(0, DL, MVT::i1), CC);
+  return DAG.getSetCC(DL, VT, AllTrue, DAG.getConstant(0, DL, MVT::i32), CC);
 }
 
 static SDValue performSETCCCombine(SDNode *N,

llvm/test/CodeGen/WebAssembly/memcmp-expand.ll

@@ -136,9 +136,8 @@ define i1 @memcmp_expand_16(ptr %a, ptr %b) {
 ; CHECK-NEXT:    v128.load $push0=, 0($1):p2align=0
 ; CHECK-NEXT:    i8x16.eq $push2=, $pop1, $pop0
 ; CHECK-NEXT:    i8x16.all_true $push3=, $pop2
-; CHECK-NEXT:    i32.const $push4=, 1
-; CHECK-NEXT:    i32.xor $push5=, $pop3, $pop4
-; CHECK-NEXT:    return $pop5
+; CHECK-NEXT:    i32.eqz $push4=, $pop3
+; CHECK-NEXT:    return $pop4
   %cmp_16 = call i32 @memcmp(ptr %a, ptr %b, i32 16)
   %res = icmp eq i32 %cmp_16, 0
   ret i1 %res