Consistently use ? instead of * for the calling convention attributes

Author: mstorsjo

compiler-rt/test/profile/instrprof-api.c

@@ -19,22 +19,22 @@ __attribute__((noinline)) int bar() { return 4; }
 
 int foo() {
   __llvm_profile_reset_counters();
-  // PROFGEN: call {{(arm_aapcs_vfpcc )*}}void @__llvm_profile_reset_counters()
-  // PROFUSE-NOT: call {{(arm_aapcs_vfpcc )*}}void @__llvm_profile_reset_counters()
+  // PROFGEN: call {{(arm_aapcs_vfpcc )?}}void @__llvm_profile_reset_counters()
+  // PROFUSE-NOT: call {{(arm_aapcs_vfpcc )?}}void @__llvm_profile_reset_counters()
   return bar();
 }
 
-// PROFUSE-NOT: declare {{(arm_aapcs_vfpcc )*}}void @__llvm_profile_reset_counters()
+// PROFUSE-NOT: declare {{(arm_aapcs_vfpcc )?}}void @__llvm_profile_reset_counters()
 
 int main() {
   int z = foo() + 3;
   __llvm_profile_set_filename("rawprof.profraw");
-  // PROFGEN: call {{(arm_aapcs_vfpcc )*}}void @__llvm_profile_set_filename(ptr noundef @{{.*}})
-  // PROFUSE-NOT: call {{(arm_aapcs_vfpcc )*}}void @__llvm_profile_set_filename(ptr noundef @{{.*}})
+  // PROFGEN: call {{(arm_aapcs_vfpcc )?}}void @__llvm_profile_set_filename(ptr noundef @{{.*}})
+  // PROFUSE-NOT: call {{(arm_aapcs_vfpcc )?}}void @__llvm_profile_set_filename(ptr noundef @{{.*}})
   if (__llvm_profile_dump())
     return 2;
-  // PROFGEN: %{{.*}} = call {{(arm_aapcs_vfpcc )*}}{{(signext )*}}i32 @__llvm_profile_dump()
-  // PROFUSE-NOT: %{{.*}} = call {{(arm_aapcs_vfpcc )*}}{{(signext )*}}i32 @__llvm_profile_dump()
+  // PROFGEN: %{{.*}} = call {{(arm_aapcs_vfpcc )?}}{{(signext )*}}i32 @__llvm_profile_dump()
+  // PROFUSE-NOT: %{{.*}} = call {{(arm_aapcs_vfpcc )?}}{{(signext )*}}i32 @__llvm_profile_dump()
   return z + bar() - 11;
 }