fx

Author: grypp

mlir/lib/IR/Remarks.cpp

@@ -243,6 +243,9 @@ void RemarkEngine::report(const Remark &&remark) {
 }
 
 RemarkEngine::~RemarkEngine() {
+  if (remarkEmittingPolicy)
+    remarkEmittingPolicy->finalize();
+
   if (remarkStreamer)
     remarkStreamer->finalize();
 }

mlir/unittests/IR/RemarkTest.cpp

@@ -368,13 +368,6 @@ TEST(Remark, TestRemarkFinal) {
         locOther,
         remark::RemarkOpts::name("Unroller").category(categoryLoopunroll))
         << pass4Msg;
-
-    // Finalize the remark engine
-    if (auto *remarkEngine = context.getRemarkEngine()) {
-      if (auto *remarkPolicy = remarkEngine->getRemarkEmittingPolicy()) {
-        remarkPolicy->finalize();
-      }
-    }
   }
 
   llvm::errs().flush();