Skip to content

Commit 1b8231c

Browse files
committed
remove target feature
1 parent c575349 commit 1b8231c

File tree

3 files changed

+4
-11
lines changed

3 files changed

+4
-11
lines changed

llvm/lib/Target/AMDGPU/AMDGPU.td

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1473,13 +1473,6 @@ def FeatureWaitsBeforeSystemScopeStores : SubtargetFeature<
14731473
"Target requires waits for loads and atomics before system scope stores"
14741474
>;
14751475

1476-
def FeaturePKF32Insts : SubtargetFeature<"pk-f32-insts",
1477-
"HasPKF32Insts",
1478-
"true",
1479-
"Has packed F32 instructions that only read 32 bits from a scalar operand "
1480-
"(SGPR or literal) and replicates the bits to both channels."
1481-
>;
1482-
14831476
// Dummy feature used to disable assembler instructions.
14841477
def FeatureDisable : SubtargetFeature<"",
14851478
"FeatureDisable","true",
@@ -2152,7 +2145,6 @@ def FeatureISAVersion12_50 : FeatureSet<
21522145
FeatureXNACK,
21532146
FeatureClusters,
21542147
FeatureD16Writes32BitVgpr,
2155-
FeaturePKF32Insts,
21562148
]>;
21572149

21582150
def FeatureISAVersion12_51 : FeatureSet<

llvm/lib/Target/AMDGPU/GCNSubtarget.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@ class GCNSubtarget final : public AMDGPUGenSubtargetInfo,
190190
bool HasEmulatedSystemScopeAtomics = false;
191191
bool HasDefaultComponentBroadcast = false;
192192
bool HasXF32Insts = false;
193-
bool HasPKF32Insts = false;
194193
/// The maximum number of instructions that may be placed within an S_CLAUSE,
195194
/// which is one greater than the maximum argument to S_CLAUSE. A value of 0
196195
/// indicates a lack of S_CLAUSE support.
@@ -1424,7 +1423,9 @@ class GCNSubtarget final : public AMDGPUGenSubtargetInfo,
14241423
/// \returns true if the target has packed f32 instructions that only read 32
14251424
/// bits from a scalar operand (SGPR or literal) and replicates the bits to
14261425
/// both channels.
1427-
bool hasPKF32Insts() const { return HasPKF32Insts; }
1426+
bool hasPKF32InstsReplicatingLow32BitsOfScalarInput() const {
1427+
return getGeneration() == GFX12 && GFX1250Insts;
1428+
}
14281429

14291430
bool hasBitOp3Insts() const { return HasBitOp3Insts; }
14301431

llvm/lib/Target/AMDGPU/SIFoldOperands.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -775,7 +775,7 @@ static void appendFoldCandidate(SmallVectorImpl<FoldCandidate> &FoldList,
775775
// 32 bits from a scalar operand (SGPR or literal) and replicates the bits to
776776
// both channels.
777777
static bool isPKF32Instr(const GCNSubtarget *ST, MachineInstr *MI) {
778-
if (!ST->hasPKF32Insts())
778+
if (!ST->hasPKF32InstsReplicatingLow32BitsOfScalarInput())
779779
return false;
780780
switch (MI->getOpcode()) {
781781
case AMDGPU::V_PK_ADD_F32:

0 commit comments

Comments
 (0)