[BOLT] Don't fail if instrumentation-sleep-time>0 and input binary don't have fini & fini_array

Author: Vasily Leonenko

bolt/lib/Rewrite/RewriteInstance.cpp

@@ -80,6 +80,7 @@ namespace opts {
 extern cl::list<std::string> HotTextMoveSections;
 extern cl::opt<bool> Hugify;
 extern cl::opt<bool> Instrument;
+extern cl::opt<uint32_t> InstrumentationSleepTime;
 extern cl::opt<bool> KeepNops;
 extern cl::opt<bool> Lite;
 extern cl::list<std::string> PrintOnly;
@@ -1501,6 +1502,10 @@ Error RewriteInstance::discoverRtFiniAddress() {
   }
 
   if (!BC->FiniArrayAddress || !BC->FiniArraySize) {
+    // It is still possible to generate profile without fini hook if
+    // InstrumentationSleepTime is set
+    if (opts::InstrumentationSleepTime > 0)
+      return Error::success();
     return createStringError(
         std::errc::not_supported,
         "Instrumentation needs either DT_FINI or DT_FINI_ARRAY");
@@ -1601,6 +1606,13 @@ void RewriteInstance::updateRtFiniReloc() {
   if (!RT || !RT->getRuntimeFiniAddress())
     return;
 
+  // It is still possible to generate profile without fini hook if
+  // InstrumentationSleepTime is set
+  if ((!BC->FiniArrayAddress || !BC->FiniArraySize) &&
+      opts::InstrumentationSleepTime > 0) {
+    return;
+  }
+
   assert(BC->FiniArrayAddress && BC->FiniArraySize &&
          "inconsistent .fini_array state");