comments

Author: makslevental

mlir/include/mlir-c/Target/LLVMIR.h

@@ -38,12 +38,18 @@ struct MlirTypeFromLLVMIRTranslator {
 
 typedef struct MlirTypeFromLLVMIRTranslator MlirTypeFromLLVMIRTranslator;
 
+/// Create an LLVM::TypeFromLLVMIRTranslator and transfer ownership to the
+/// caller.
 MLIR_CAPI_EXPORTED MlirTypeFromLLVMIRTranslator
 mlirTypeFromLLVMIRTranslatorCreate(MlirContext ctx);
 
-MLIR_CAPI_EXPORTED MlirTypeFromLLVMIRTranslator
-mlirTypeFromLLVMIRTranslatorCreate(MlirContext ctx);
+/// Takes an LLVM::TypeFromLLVMIRTranslator owned by the caller and destroys it.
+/// It is the responsibility of the user to only pass an
+/// LLVM::TypeFromLLVMIRTranslator class.
+MLIR_CAPI_EXPORTED void
+mlirTypeFromLLVMIRTranslatorDestroy(MlirTypeFromLLVMIRTranslator translator);
 
+/// Translates the given LLVM IR type to the MLIR LLVM dialect.
 MLIR_CAPI_EXPORTED MlirType mlirTypeFromLLVMIRTranslatorTranslateType(
     MlirTypeFromLLVMIRTranslator translator, LLVMTypeRef llvmType);
 

mlir/lib/CAPI/Target/LLVMIR.cpp

@@ -44,9 +44,14 @@ mlirTypeFromLLVMIRTranslatorCreate(MlirContext ctx) {
   return wrap(translator);
 }
 
+void mlirTypeFromLLVMIRTranslatorDestroy(
+    MlirTypeFromLLVMIRTranslator translator) {
+  delete static_cast<LLVM::TypeFromLLVMIRTranslator *>(unwrap(translator));
+}
+
 MlirType mlirTypeFromLLVMIRTranslatorTranslateType(
     MlirTypeFromLLVMIRTranslator translator, LLVMTypeRef llvmType) {
   LLVM::TypeFromLLVMIRTranslator *translator_ = unwrap(translator);
   mlir::Type type = translator_->translateType(llvm::unwrap(llvmType));
   return wrap(type);
-}
+}