Skip to content

Commit 1c786a1

Browse files
committed
Migrate clangd away from -fno-delayed-template-parsing
1 parent d3ed992 commit 1c786a1

File tree

4 files changed

+1
-6
lines changed

4 files changed

+1
-6
lines changed

clang-tools-extra/clangd/unittests/ParsedASTTests.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ TEST(ParsedASTTest,
203203
AllOf(declNamed("foo"), withTemplateArgs("<bool>"))}));
204204
}
205205

206-
TEST(ParsedASTTest, IgnoresDelayedTemplateParsing) {
206+
TEST(ParsedASTTest, WorksEvenWithDelayedTemplateParsing) {
207207
auto TU = TestTU::withCode(R"cpp(
208208
template <typename T> void xxx() {
209209
int yyy = 0;

clang-tools-extra/clangd/unittests/RenameTests.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1382,7 +1382,6 @@ TEST(RenameTest, Renameable) {
13821382
SCOPED_TRACE(Case.Code);
13831383
Annotations T(Case.Code);
13841384
TestTU TU = TestTU::withCode(T.code());
1385-
TU.ExtraArgs.push_back("-fno-delayed-template-parsing");
13861385
if (Case.IsHeaderFile) {
13871386
// We open the .h file as the main file.
13881387
TU.Filename = "test.h";

clang-tools-extra/clangd/unittests/XRefsTests.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1418,9 +1418,6 @@ TEST(LocateSymbol, Ambiguous) {
14181418
}
14191419
)cpp");
14201420
auto TU = TestTU::withCode(T.code());
1421-
// FIXME: Go-to-definition in a template requires disabling delayed template
1422-
// parsing.
1423-
TU.ExtraArgs.push_back("-fno-delayed-template-parsing");
14241421
auto AST = TU.build();
14251422
// Ordered assertions are deliberate: we expect a predictable order.
14261423
EXPECT_THAT(locateSymbolAt(AST, T.point("1")), ElementsAre(sym("str")));

clang-tools-extra/unittests/clang-tidy/ClangTidyTest.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ runCheckOnCode(StringRef Code, std::vector<ClangTidyError> *Errors = nullptr,
104104

105105
std::vector<std::string> Args(1, "clang-tidy");
106106
Args.push_back("-fsyntax-only");
107-
Args.push_back("-fno-delayed-template-parsing");
108107
std::string extension(
109108
std::string(llvm::sys::path::extension(Filename.str())));
110109
if (extension == ".m" || extension == ".mm") {

0 commit comments

Comments
 (0)