review: remove unreachable return true

inbelic · inbelic · commit 1d078242ac1f · 2025-02-14T19:31:45.000Z
diff --git a/clang/lib/Parse/ParseHLSLRootSignature.cpp b/clang/lib/Parse/ParseHLSLRootSignature.cpp
@@ -89,10 +89,9 @@ bool RootSignatureParser::ParseRootElement() {
   switch (CurToken.Kind) {
   case TokenKind::kw_DescriptorTable:
     return ParseDescriptorTable();
-  default:
-    llvm_unreachable("Switch for an expected token was not provided");
+  default: break;
   }
-  return true;
+  llvm_unreachable("Switch for an expected token was not provided");
 }
 
 bool RootSignatureParser::ParseDescriptorTable() {

Original file line number	Diff line number	Diff line change
`@@ -89,10 +89,9 @@ bool RootSignatureParser::ParseRootElement() {`
`89`	`89`	`switch (CurToken.Kind) {`
`90`	`90`	`case TokenKind::kw_DescriptorTable:`
`91`	`91`	`return ParseDescriptorTable();`
`92`		`- default:`
`93`		`- llvm_unreachable("Switch for an expected token was not provided");`
	`92`	`+ default: break;`
`94`	`93`	`}`
`95`		`- return true;`
	`94`	`+ llvm_unreachable("Switch for an expected token was not provided");`
`96`	`95`	`}`
`97`	`96`
`98`	`97`	`bool RootSignatureParser::ParseDescriptorTable() {`