Skip to content

Commit 1d90050

Browse files
committed
fixup! Changes after @ojhunt's review on 2025-09-09 (#157779)
Changes after @ojhunt's review on 2025-09-10 (#157779)
1 parent bc4d0a7 commit 1d90050

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

clang/lib/Sema/SemaDecl.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8363,8 +8363,7 @@ NamedDecl *Sema::ActOnVariableDeclarator(
83638363
NewVD->isFunctionPointerType() && !NewVD->isExternallyVisible()) {
83648364
PointerAuthQualifier Q = NewVD->getType().getQualifiers().getPointerAuth();
83658365
if (!Q || (!Q.isAddressDiscriminated() && Q.getExtraDiscriminator() == 0)) {
8366-
Diag(NewVD->getLocation(), diag::warn_ptrauth_weak_schema)
8367-
<< NewVD << (Q ? 0 : 1);
8366+
Diag(NewVD->getLocation(), diag::warn_ptrauth_weak_schema) << NewVD << !Q;
83688367
}
83698368
}
83708369

clang/test/Sema/ptrauth-weak-schema.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55

66
#include <ptrauth.h>
77

8+
#if defined(__PTRAUTH__) == defined(NO_PTRAUTH)
9+
#error expected pointer authentication state does not match actual
10+
#endif
11+
812
#if defined(NO_PTRAUTH)
913
#define FN_PTR_AUTH(address_diversity, constant_discriminator)
1014
#else

0 commit comments

Comments
 (0)