Skip to content

Commit 1de314f

Browse files
davemgreentru
authored andcommitted
[AArch64] Correct the regtype of indexed fmlal
The indexed fmlal should use a low numbered register for the index operand, which this fixes by making it V128_lo. Fixes 64104 Differential Revision: https://reviews.llvm.org/D156296 (cherry picked from commit 509cb33)
1 parent 1993d2f commit 1de314f

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

llvm/lib/Target/AArch64/AArch64InstrFormats.td

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8440,12 +8440,12 @@ class BaseSIMDThreeSameVectorFMLIndex<bit Q, bit U, bits<4> opc, string asm,
84408440
string rhs_kind, RegisterOperand RegType,
84418441
ValueType AccumType, ValueType InputType,
84428442
SDPatternOperator OpNode> :
8443-
BaseSIMDIndexedTied<Q, U, 0, 0b10, opc, RegType, RegType, V128,
8443+
BaseSIMDIndexedTied<Q, U, 0, 0b10, opc, RegType, RegType, V128_lo,
84448444
VectorIndexH, asm, "", dst_kind, lhs_kind, rhs_kind,
84458445
[(set (AccumType RegType:$dst),
84468446
(AccumType (OpNode (AccumType RegType:$Rd),
84478447
(InputType RegType:$Rn),
8448-
(InputType (AArch64duplane16 (v8f16 V128:$Rm),
8448+
(InputType (AArch64duplane16 (v8f16 V128_lo:$Rm),
84498449
VectorIndexH:$idx)))))]> {
84508450
// idx = H:L:M
84518451
bits<3> idx;

llvm/test/CodeGen/AArch64/fmlal-loreg.ll

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,24 @@
77
define <4 x float> @test(ptr %lhs_panel, ptr %rhs_panel, <4 x float> %a) {
88
; CHECK-LABEL: test:
99
; CHECK: // %bb.0: // %entry
10+
; CHECK-NEXT: str d8, [sp, #-16]! // 8-byte Folded Spill
11+
; CHECK-NEXT: .cfi_def_cfa_offset 16
12+
; CHECK-NEXT: .cfi_offset b8, -16
1013
; CHECK-NEXT: fmov x8, d0
11-
; CHECK-NEXT: ldr q16, [x0]
12-
; CHECK-NEXT: ldr q17, [x1]
14+
; CHECK-NEXT: ldr q8, [x0]
15+
; CHECK-NEXT: ldr q16, [x1]
1316
; CHECK-NEXT: lsr x9, x8, #32
1417
; CHECK-NEXT: //APP
1518
; CHECK-NEXT: nop
1619
; CHECK-NEXT: //NO_APP
1720
; CHECK-NEXT: mov w8, w8
1821
; CHECK-NEXT: orr x8, x8, x9, lsl #32
1922
; CHECK-NEXT: fmov d0, x8
20-
; CHECK-NEXT: fmlal v0.4s, v17.4h, v16.h[0]
23+
; CHECK-NEXT: fmlal v0.4s, v16.4h, v8.h[0]
2124
; CHECK-NEXT: mov v1.16b, v0.16b
22-
; CHECK-NEXT: fmlal2 v1.4s, v17.4h, v16.h[0]
25+
; CHECK-NEXT: fmlal2 v1.4s, v16.4h, v8.h[0]
2326
; CHECK-NEXT: fadd v0.4s, v0.4s, v1.4s
27+
; CHECK-NEXT: ldr d8, [sp], #16 // 8-byte Folded Reload
2428
; CHECK-NEXT: ret
2529
entry:
2630
%0 = load <8 x half>, ptr %lhs_panel, align 2

0 commit comments

Comments
 (0)