remove signed int representation assert it breaks CodeGen/AArch64/sve-vector-arith-ops.c test case use of i8s

farzonl · farzonl · commit 1e736777183d · 2025-04-10T12:34:21.000-04:00
diff --git a/clang/lib/CodeGen/CGExprScalar.cpp b/clang/lib/CodeGen/CGExprScalar.cpp
@@ -3968,8 +3968,6 @@ Value *ScalarExprEmitter::EmitRem(const BinOpInfo &Ops) {
   if (CGF.getLangOpts().HLSL && Ops.Ty->hasFloatingRepresentation())
     return Builder.CreateFRem(Ops.LHS, Ops.RHS, "rem");
 
-  assert(Ops.Ty->hasSignedIntegerRepresentation() &&
-         "Srem expected a signed integer representation.");
   return Builder.CreateSRem(Ops.LHS, Ops.RHS, "rem");
 }
 

Original file line number	Diff line number	Diff line change
`@@ -3968,8 +3968,6 @@ Value *ScalarExprEmitter::EmitRem(const BinOpInfo &Ops) {`
`3968`	`3968`	`if (CGF.getLangOpts().HLSL && Ops.Ty->hasFloatingRepresentation())`
`3969`	`3969`	`return Builder.CreateFRem(Ops.LHS, Ops.RHS, "rem");`
`3970`	`3970`
`3971`		`- assert(Ops.Ty->hasSignedIntegerRepresentation() &&`
`3972`		`- "Srem expected a signed integer representation.");`
`3973`	`3971`	`return Builder.CreateSRem(Ops.LHS, Ops.RHS, "rem");`
`3974`	`3972`	`}`
`3975`	`3973`