Change v[i] == false to !v[i] as it's type is boolean-testable

frederick-vs-ja · frederick-vs-ja · commit 1ec0c23ead69 · 2025-06-11T20:56:21.000+08:00
diff --git a/libcxx/test/std/utilities/template.bitset/bitset.cons/char_ptr_ctor.pass.cpp b/libcxx/test/std/utilities/template.bitset/bitset.cons/char_ptr_ctor.pass.cpp
@@ -81,7 +81,7 @@ TEST_CONSTEXPR_CXX23 void test_char_pointer_ctor()
     for (std::size_t i = 0; i < M; ++i)
       assert(v[i] == (not_null_terminated[M - 1 - i] == '1'));
     for (std::size_t i = 10; i < v.size(); ++i)
-      assert(v[i] == false);
+      assert(!v[i]);
   }
   {
     const char not_null_terminated[] = {'1', 'a', '1', 'a', '1', 'a', '1', 'a', '1', 'a'};
@@ -90,7 +90,7 @@ TEST_CONSTEXPR_CXX23 void test_char_pointer_ctor()
     for (std::size_t i = 0; i < M; ++i)
       assert(v[i] == (not_null_terminated[M - 1 - i] == '1'));
     for (std::size_t i = 10; i < v.size(); ++i)
-      assert(v[i] == false);
+      assert(!v[i]);
   }
   {
     const char not_null_terminated[] = {'b', 'a', 'b', 'a', 'b', 'a', 'b', 'a', 'b', 'a'};
@@ -99,7 +99,7 @@ TEST_CONSTEXPR_CXX23 void test_char_pointer_ctor()
     for (std::size_t i = 0; i < M; ++i)
       assert(v[i] == (not_null_terminated[M - 1 - i] == 'b'));
     for (std::size_t i = 10; i < v.size(); ++i)
-      assert(v[i] == false);
+      assert(!v[i]);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ TEST_CONSTEXPR_CXX23 void test_char_pointer_ctor()`
`81`	`81`	`for (std::size_t i = 0; i < M; ++i)`
`82`	`82`	`assert(v[i] == (not_null_terminated[M - 1 - i] == '1'));`
`83`	`83`	`for (std::size_t i = 10; i < v.size(); ++i)`
`84`		`- assert(v[i] == false);`
	`84`	`+ assert(!v[i]);`
`85`	`85`	`}`
`86`	`86`	`{`
`87`	`87`	`const char not_null_terminated[] = {'1', 'a', '1', 'a', '1', 'a', '1', 'a', '1', 'a'};`
`@@ -90,7 +90,7 @@ TEST_CONSTEXPR_CXX23 void test_char_pointer_ctor()`
`90`	`90`	`for (std::size_t i = 0; i < M; ++i)`
`91`	`91`	`assert(v[i] == (not_null_terminated[M - 1 - i] == '1'));`
`92`	`92`	`for (std::size_t i = 10; i < v.size(); ++i)`
`93`		`- assert(v[i] == false);`
	`93`	`+ assert(!v[i]);`
`94`	`94`	`}`
`95`	`95`	`{`
`96`	`96`	`const char not_null_terminated[] = {'b', 'a', 'b', 'a', 'b', 'a', 'b', 'a', 'b', 'a'};`
`@@ -99,7 +99,7 @@ TEST_CONSTEXPR_CXX23 void test_char_pointer_ctor()`
`99`	`99`	`for (std::size_t i = 0; i < M; ++i)`
`100`	`100`	`assert(v[i] == (not_null_terminated[M - 1 - i] == 'b'));`
`101`	`101`	`for (std::size_t i = 10; i < v.size(); ++i)`
`102`		`- assert(v[i] == false);`
	`102`	`+ assert(!v[i]);`
`103`	`103`	`}`
`104`	`104`	`}`
`105`	`105`