add index and count to the moduleSymbols request

Author: eronnen

lldb/tools/lldb-dap/Handler/ModuleSymbolsRequestHandler.cpp

@@ -51,8 +51,10 @@ ModuleSymbolsRequestHandler::Run(const ModuleSymbolsArguments &args) const {
   if (!module.IsValid())
     return llvm::make_error<DAPError>("Module not found");
 
-  size_t num_symbols = module.GetNumSymbols();
-  for (size_t i = 0; i < num_symbols; ++i) {
+  const size_t num_symbols = module.GetNumSymbols();
+  const size_t start_index = args.startIndex.value_or(0);
+  const size_t end_index = std::min(start_index + args.count.value_or(num_symbols), num_symbols);
+  for (size_t i = start_index; i < end_index; ++i) {
     lldb::SBSymbol symbol = module.GetSymbolAtIndex(i);
     if (!symbol.IsValid())
       continue;

lldb/tools/lldb-dap/Protocol/ProtocolRequests.cpp

@@ -601,8 +601,10 @@ json::Value toJSON(const WriteMemoryResponseBody &WMR) {
 bool fromJSON(const llvm::json::Value &Params, ModuleSymbolsArguments &Args,
               llvm::json::Path P) {
   json::ObjectMapper O(Params, P);
-  return O && O.mapOptional("moduleId", Args.moduleId) &&
-         O.mapOptional("moduleName", Args.moduleName);
+  return O && O.map("moduleId", Args.moduleId) &&
+         O.map("moduleName", Args.moduleName) &&
+         O.mapOptional("startIndex", Args.startIndex) &&
+         O.mapOptional("count", Args.count);
 }
 
 llvm::json::Value toJSON(const ModuleSymbolsResponseBody &DGMSR) {

lldb/tools/lldb-dap/Protocol/ProtocolRequests.h

@@ -987,6 +987,12 @@ struct ModuleSymbolsArguments {
 
   /// The module path.
   std::string moduleName;
+
+  /// The index of the first symbol to return; if omitted, start at the beginning.
+  std::optional<uint32_t> startIndex;
+
+  /// The number of symbols to return; if omitted, all symbols are returned.
+  std::optional<uint32_t> count;
 };
 bool fromJSON(const llvm::json::Value &, ModuleSymbolsArguments &,
               llvm::json::Path);

lldb/tools/lldb-dap/src-ts/ui/symbols-provider.ts

@@ -44,7 +44,7 @@ export class SymbolsProvider extends DisposableContext {
       });
     });
 
-    this.tracker.onDidExitSession((session) => {
+    this.tracker.onDidExitSession((_session) => {
       vscode.commands.executeCommand("setContext", "lldb-dap.supportsModuleSymbolsRequest", false);
     });
   }