Skip to content

Commit 1f3f547

Browse files
committed
Fix and expand comment in test.
1 parent 3bcdc0d commit 1f3f547

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

clang/unittests/Analysis/FlowSensitive/TransferTest.cpp

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3778,8 +3778,11 @@ void target(Base* B, Base* OtherB) {
37783778
ASTContext &ASTCtx) {
37793779
// This is a crash repro. We used to crash when transferring the
37803780
// copy construction of B from OtherB because B's StorageLocation had a
3781-
// child for the field C, but Base doesn't. Now, we should only copy the
3782-
// fields from B that are present in Base.
3781+
// child for the field C, but Base doesn't (so OtherB doesn't, since
3782+
// it's never been cast to any other type), and we tried to copy from
3783+
// the source (OtherB) all the fields present in the destination (B).
3784+
// Now, we should only try to copy the fields from OtherB that are
3785+
// present in Base.
37833786
});
37843787
}
37853788

@@ -5394,7 +5397,7 @@ TEST(TransferTest, UnsupportedValueEquality) {
53945397
A,
53955398
B
53965399
};
5397-
5400+
53985401
void target() {
53995402
EC ec = EC::A;
54005403

0 commit comments

Comments
 (0)