Skip to content

Commit 1f655ec

Browse files
committed
Fix test case
1 parent 1d0cf67 commit 1f655ec

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -874,6 +874,8 @@ def request_next(self, threadId, granularity="statement"):
874874
def request_stepIn(self, threadId, targetId, granularity="statement"):
875875
if self.exit_status is not None:
876876
raise ValueError("request_stepIn called after process exited")
877+
if threadId is None:
878+
threadId = self.get_thread_id()
877879
args_dict = {
878880
"threadId": threadId,
879881
"targetId": targetId,

lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,9 +238,10 @@ def set_global(self, name, value, id=None):
238238
def stepIn(
239239
self, threadId=None, targetId=None, waitForStop=True, granularity="statement"
240240
):
241-
self.dap_server.request_stepIn(
241+
response = self.dap_server.request_stepIn(
242242
threadId=threadId, targetId=targetId, granularity=granularity
243243
)
244+
assert response["success"] is True
244245
if waitForStop:
245246
return self.dap_server.wait_for_stopped()
246247
return None

lldb/test/API/tools/lldb-dap/breakpoint/TestDAP_setBreakpoints.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ def test_column_breakpoints(self):
380380
# Step into and check we are inside `twelve`.
381381
self.stepIn()
382382
func_name = self.get_stackFrames()[0]["name"]
383-
self.assertEqual(func_name, "twelve")
383+
self.assertEqual(func_name, "twelve(int)")
384384

385385
# Continue to the second breakpoint.
386386
self.continue_to_breakpoints([breakpoint_ids[1]])
@@ -389,4 +389,4 @@ def test_column_breakpoints(self):
389389
# Step into and check we are inside `fourteen`.
390390
self.stepIn()
391391
func_name = self.get_stackFrames()[0]["name"]
392-
self.assertEqual(func_name, "a::fourteen")
392+
self.assertEqual(func_name, "a::fourteen(int)")

0 commit comments

Comments
 (0)