Skip to content

Commit 1ff9bed

Browse files
committed
Merging r356039:
------------------------------------------------------------------------ r356039 | atanasyan | 2019-03-13 04:04:38 -0700 (Wed, 13 Mar 2019) | 11 lines [MIPS][microMIPS] Fix PseudoMTLOHI_MM matching and expansion On micromips MipsMTLOHI is always matched to PseudoMTLOHI_DSP regardless of +dsp argument. This patch checks is HasDSP predicate is present for PseudoMTLOHI_DSP so PseudoMTLOHI_MM can be matched when appropriate. Add expansion of PseudoMTLOHI_MM instruction into a mtlo/mthi pair. Patch by Mirko Brkusanin. Differential Revision: http://reviews.llvm.org/D59203 ------------------------------------------------------------------------ llvm-svn: 358941
1 parent 047302e commit 1ff9bed

File tree

3 files changed

+69
-1
lines changed

3 files changed

+69
-1
lines changed

llvm/lib/Target/Mips/MipsDSPInstrInfo.td

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1314,7 +1314,9 @@ def PseudoCMPU_LE_QB : PseudoCMP<CMPU_LE_QB>;
13141314
def PseudoPICK_PH : PseudoPICK<PICK_PH>;
13151315
def PseudoPICK_QB : PseudoPICK<PICK_QB>;
13161316

1317-
def PseudoMTLOHI_DSP : PseudoMTLOHI<ACC64DSP, GPR32>;
1317+
let AdditionalPredicates = [HasDSP] in {
1318+
def PseudoMTLOHI_DSP : PseudoMTLOHI<ACC64DSP, GPR32>;
1319+
}
13181320

13191321
// Patterns.
13201322
class DSPPat<dag pattern, dag result, Predicate pred = HasDSP> :

llvm/lib/Target/Mips/MipsSEInstrInfo.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -447,6 +447,9 @@ bool MipsSEInstrInfo::expandPostRAPseudo(MachineInstr &MI) const {
447447
case Mips::PseudoMTLOHI_DSP:
448448
expandPseudoMTLoHi(MBB, MI, Mips::MTLO_DSP, Mips::MTHI_DSP, true);
449449
break;
450+
case Mips::PseudoMTLOHI_MM:
451+
expandPseudoMTLoHi(MBB, MI, Mips::MTLO_MM, Mips::MTHI_MM, false);
452+
break;
450453
case Mips::PseudoCVT_S_W:
451454
expandCvtFPInt(MBB, MI, Mips::CVT_S_W, Mips::MTC1, false);
452455
break;
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
2+
; RUN: llc -mtriple=mipsel-linux-gnu -mcpu=mips32r2 -mattr=+micromips -asm-show-inst < %s |\
3+
; RUN: FileCheck %s -check-prefixes=MMR2
4+
; RUN: llc -mtriple=mipsel-linux-gnu -mcpu=mips32r2 -mattr=+dsp,+micromips -asm-show-inst < %s |\
5+
; RUN: FileCheck %s -check-prefixes=MMR2-DSP
6+
7+
define i64 @test(i32 signext %a, i32 signext %b) {
8+
; MMR2-LABEL: test:
9+
; MMR2: # %bb.0: # %entry
10+
; MMR2-NEXT: li16 $2, 0 # <MCInst #{{[0-9]+}} LI16_MM
11+
; MMR2-NEXT: # <MCOperand Reg:321>
12+
; MMR2-NEXT: # <MCOperand Imm:0>>
13+
; MMR2-NEXT: li16 $3, 1 # <MCInst #{{[0-9]+}} LI16_MM
14+
; MMR2-NEXT: # <MCOperand Reg:322>
15+
; MMR2-NEXT: # <MCOperand Imm:1>>
16+
; MMR2-NEXT: mtlo $3 # <MCInst #{{[0-9]+}} MTLO_MM
17+
; MMR2-NEXT: # <MCOperand Reg:322>>
18+
; MMR2-NEXT: mthi $2 # <MCInst #{{[0-9]+}} MTHI_MM
19+
; MMR2-NEXT: # <MCOperand Reg:321>>
20+
; MMR2-NEXT: madd $4, $5 # <MCInst #{{[0-9]+}} MADD
21+
; MMR2-NEXT: # <MCOperand Reg:22>
22+
; MMR2-NEXT: # <MCOperand Reg:23>>
23+
; MMR2-NEXT: mflo16 $2 # <MCInst #{{[0-9]+}} MFLO16_MM
24+
; MMR2-NEXT: # <MCOperand Reg:321>>
25+
; MMR2-NEXT: mfhi16 $3 # <MCInst #{{[0-9]+}} MFHI16_MM
26+
; MMR2-NEXT: # <MCOperand Reg:322>>
27+
; MMR2-NEXT: jrc $ra # <MCInst #{{[0-9]+}} JRC16_MM
28+
; MMR2-NEXT: # <MCOperand Reg:19>>
29+
;
30+
; MMR2-DSP-LABEL: test:
31+
; MMR2-DSP: # %bb.0: # %entry
32+
; MMR2-DSP-NEXT: li16 $2, 0 # <MCInst #{{[0-9]+}} LI16_MM
33+
; MMR2-DSP-NEXT: # <MCOperand Reg:321>
34+
; MMR2-DSP-NEXT: # <MCOperand Imm:0>>
35+
; MMR2-DSP-NEXT: li16 $3, 1 # <MCInst #{{[0-9]+}} LI16_MM
36+
; MMR2-DSP-NEXT: # <MCOperand Reg:322>
37+
; MMR2-DSP-NEXT: # <MCOperand Imm:1>>
38+
; MMR2-DSP-NEXT: mtlo $3, $ac0 # <MCInst #{{[0-9]+}} MTLO_DSP
39+
; MMR2-DSP-NEXT: # <MCOperand Reg:291>
40+
; MMR2-DSP-NEXT: # <MCOperand Reg:322>>
41+
; MMR2-DSP-NEXT: mthi $2, $ac0 # <MCInst #{{[0-9]+}} MTHI_DSP
42+
; MMR2-DSP-NEXT: # <MCOperand Reg:253>
43+
; MMR2-DSP-NEXT: # <MCOperand Reg:321>>
44+
; MMR2-DSP-NEXT: madd $ac0, $4, $5 # <MCInst #{{[0-9]+}} MADD_DSP
45+
; MMR2-DSP-NEXT: # <MCOperand Reg:26>
46+
; MMR2-DSP-NEXT: # <MCOperand Reg:22>
47+
; MMR2-DSP-NEXT: # <MCOperand Reg:23>
48+
; MMR2-DSP-NEXT: # <MCOperand Reg:26>>
49+
; MMR2-DSP-NEXT: mflo $2, $ac0 # <MCInst #{{[0-9]+}} MFLO_DSP
50+
; MMR2-DSP-NEXT: # <MCOperand Reg:321>
51+
; MMR2-DSP-NEXT: # <MCOperand Reg:26>>
52+
; MMR2-DSP-NEXT: jr $ra # <MCInst #{{[0-9]+}} JR_MM
53+
; MMR2-DSP-NEXT: # <MCOperand Reg:19>>
54+
; MMR2-DSP-NEXT: mfhi $3, $ac0 # <MCInst #{{[0-9]+}} MFHI_DSP
55+
; MMR2-DSP-NEXT: # <MCOperand Reg:322>
56+
; MMR2-DSP-NEXT: # <MCOperand Reg:26>>
57+
entry:
58+
%conv = sext i32 %a to i64
59+
%conv1 = sext i32 %b to i64
60+
%mul = mul nsw i64 %conv, %conv1
61+
%add = add nsw i64 %mul, 1
62+
ret i64 %add
63+
}

0 commit comments

Comments
 (0)