Skip to content

Commit 202b09c

Browse files
author
Alexander Johnston
committed
Revert unneeded SPIR-V target changes
1 parent 120e889 commit 202b09c

File tree

5 files changed

+0
-98
lines changed

5 files changed

+0
-98
lines changed

clang/include/clang/Basic/BuiltinsSPIRVVK.td

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,3 @@ include "clang/Basic/BuiltinsSPIRVBase.td"
1212
def reflect : SPIRVBuiltin<"void(...)", [NoThrow, Const]>;
1313
def faceforward : SPIRVBuiltin<"void(...)", [NoThrow, Const, CustomTypeChecking]>;
1414
def refract : SPIRVBuiltin<"void(...)", [NoThrow, Const, CustomTypeChecking]>;
15-
def ddx_coarse : SPIRVBuiltin<"void(...)", [NoThrow, Const, CustomTypeChecking]>;
16-
def ddy_coarse : SPIRVBuiltin<"void(...)", [NoThrow, Const, CustomTypeChecking]>;

clang/lib/CodeGen/TargetBuiltins/SPIR.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -151,18 +151,6 @@ Value *CodeGenFunction::EmitSPIRVBuiltinExpr(unsigned BuiltinID,
151151
Intrinsic::spv_global_offset,
152152
ArrayRef<Value *>{EmitScalarExpr(E->getArg(0))}, nullptr,
153153
"spv.global.offset");
154-
case SPIRV::BI__builtin_spirv_ddx_coarse:
155-
return Builder.CreateIntrinsic(
156-
/*ReturnType=*/getTypes().ConvertType(E->getType()),
157-
Intrinsic::spv_ddx_coarse,
158-
ArrayRef<Value *>{EmitScalarExpr(E->getArg(0))}, nullptr,
159-
"spv.ddx.coarse");
160-
case SPIRV::BI__builtin_spirv_ddy_coarse:
161-
return Builder.CreateIntrinsic(
162-
/*ReturnType=*/getTypes().ConvertType(E->getType()),
163-
Intrinsic::spv_ddy_coarse,
164-
ArrayRef<Value *>{EmitScalarExpr(E->getArg(0))}, nullptr,
165-
"spv.ddy.coarse");
166154
}
167155
return nullptr;
168156
}

clang/lib/Sema/SemaSPIRV.cpp

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -46,19 +46,6 @@ static bool CheckAllArgsHaveSameType(Sema *S, CallExpr *TheCall) {
4646
return false;
4747
}
4848

49-
static bool CheckAllArgTypesAreCorrect(
50-
Sema *S, CallExpr *TheCall,
51-
llvm::function_ref<bool(Sema *S, SourceLocation Loc, int ArgOrdinal,
52-
clang::QualType PassedType)>
53-
Check) {
54-
for (unsigned I = 0; I < TheCall->getNumArgs(); ++I) {
55-
Expr *Arg = TheCall->getArg(I);
56-
if (Check(S, Arg->getBeginLoc(), I + 1, Arg->getType()))
57-
return true;
58-
}
59-
return false;
60-
}
61-
6249
static bool CheckAllArgTypesAreCorrect(
6350
Sema *S, CallExpr *TheCall,
6451
llvm::ArrayRef<
@@ -373,19 +360,6 @@ bool SemaSPIRV::CheckSPIRVBuiltinFunctionCall(const TargetInfo &TI,
373360
case SPIRV::BI__builtin_spirv_generic_cast_to_ptr_explicit: {
374361
return checkGenericCastToPtr(SemaRef, TheCall);
375362
}
376-
case SPIRV::BI__builtin_spirv_ddx_coarse:
377-
case SPIRV::BI__builtin_spirv_ddy_coarse: {
378-
if (SemaRef.checkArgCount(TheCall, 1))
379-
return true;
380-
381-
if (CheckAllArgTypesAreCorrect(&SemaRef, TheCall,
382-
CheckFloatOrHalfRepresentation))
383-
return true;
384-
385-
QualType RetTy = TheCall->getArg(0)->getType();
386-
TheCall->setType(RetTy);
387-
break;
388-
}
389363
}
390364
return false;
391365
}

clang/test/SemaSPIRV/BuiltIns/ddx-coarse-errors.c

Lines changed: 0 additions & 29 deletions
This file was deleted.

clang/test/SemaSPIRV/BuiltIns/ddy-coarse-errors.c

Lines changed: 0 additions & 29 deletions
This file was deleted.

0 commit comments

Comments
 (0)