Switch to const reference

Author: Jlalond

lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp

@@ -925,14 +925,14 @@ llvm::Error ProcessElfCore::parseLinuxNotes(llvm::ArrayRef<CoreNote> notes) {
       break;
     }
     case ELF::NT_SIGINFO: {
-      lldb::UnixSignalsSP unix_signals_sp = GetUnixSignals();
+      const lldb_private::UnixSignals &unix_signals = *GetUnixSignals();
       ELFLinuxSigInfo siginfo;
-      Status status = siginfo.Parse(note.data, arch, unix_signals_sp);
+      Status status = siginfo.Parse(note.data, arch, unix_signals);
       if (status.Fail())
         return status.ToError();
       thread_data.signo = siginfo.si_signo;
       thread_data.code = siginfo.si_code;
-      thread_data.description = siginfo.GetDescription(unix_signals_sp);
+      thread_data.description = siginfo.GetDescription(unix_signals);
       break;
     }
     case ELF::NT_FILE: {

lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp

@@ -543,7 +543,7 @@ size_t ELFLinuxSigInfo::GetSize(const lldb_private::ArchSpec &arch) {
 }
 
 Status ELFLinuxSigInfo::Parse(const DataExtractor &data, const ArchSpec &arch,
-                              const lldb::UnixSignalsSP unix_signals_sp) {
+                              const lldb_private::UnixSignals &unix_signals) {
   Status error;
   uint64_t size = GetSize(arch);
   if (size > data.GetByteSize()) {
@@ -563,8 +563,8 @@ Status ELFLinuxSigInfo::Parse(const DataExtractor &data, const ArchSpec &arch,
   if (data.GetAddressByteSize() == 8)
     offset += 4;
   // Not every stop signal has a valid address, but that will get resolved in
-  // the unix_signals_sp->GetSignalDescription() call below.
-  if (unix_signals_sp->GetShouldStop(si_signo)) {
+  // the unix_signals.GetSignalDescription() call below.
+  if (unix_signals.GetShouldStop(si_signo)) {
     // Instead of memcpy we call all these individually as the extractor will
     // handle endianness for us.
     _sigfault.sig_addr = data.GetAddress(&offset);
@@ -585,17 +585,17 @@ Status ELFLinuxSigInfo::Parse(const DataExtractor &data, const ArchSpec &arch,
 }
 
 std::string
-ELFLinuxSigInfo::GetDescription(const lldb::UnixSignalsSP unix_signals_sp) {
-  if (unix_signals_sp->GetShouldStop(si_signo)) {
+ELFLinuxSigInfo::GetDescription(const lldb_private::UnixSignals &unix_signals) {
+  if (unix_signals.GetShouldStop(si_signo)) {
     if (_sigfault._bounds._addr_bnd._upper != 0)
-      return unix_signals_sp->GetSignalDescription(
+      return unix_signals.GetSignalDescription(
           si_signo, si_code, _sigfault.sig_addr,
           _sigfault._bounds._addr_bnd._lower,
           _sigfault._bounds._addr_bnd._upper);
     else
-      return unix_signals_sp->GetSignalDescription(si_signo, si_code,
+      return unix_signals.GetSignalDescription(si_signo, si_code,
                                                    _sigfault.sig_addr);
   }
 
-  return unix_signals_sp->GetSignalDescription(si_signo, si_code);
+  return unix_signals.GetSignalDescription(si_signo, si_code);
 }

lldb/source/Plugins/Process/elf-core/ThreadElfCore.h

@@ -100,9 +100,9 @@ struct ELFLinuxSigInfo {
 
   lldb_private::Status Parse(const lldb_private::DataExtractor &data,
                              const lldb_private::ArchSpec &arch,
-                             const lldb::UnixSignalsSP unix_signals_sp);
+                             const lldb_private::UnixSignals &unix_signals);
 
-  std::string GetDescription(const lldb::UnixSignalsSP unix_signals_sp);
+  std::string GetDescription(const lldb_private::UnixSignals &unix_signals);
 
   // Return the bytesize of the structure
   // 64 bit - just sizeof