modify code with best practices

Author: Prakhar-Dixit

mlir/lib/Dialect/Affine/Transforms/SuperVectorize.cpp

@@ -24,6 +24,7 @@
 #include "mlir/Dialect/Vector/IR/VectorOps.h"
 #include "mlir/Dialect/Vector/Utils/VectorUtils.h"
 #include "mlir/IR/IRMapping.h"
+#include "mlir/IR/Value.h"
 #include "mlir/Pass/Pass.h"
 #include "mlir/Support/LLVM.h"
 #include "llvm/ADT/STLExtras.h"
@@ -1192,19 +1193,20 @@ static bool isIVMappedToMultipleIndices(
   for (auto &kvp : loopToVectorDim) {
     AffineForOp forOp = cast<AffineForOp>(kvp.first);
     // Find which indices are invariant w.r.t. this loop IV.
-    auto invariants =
+    llvm::DenseSet<Value> invariants =
         affine::getInvariantAccesses(forOp.getInductionVar(), indices);
     // Count how many vary (i.e. are not invariant).
     unsigned nonInvariant = 0;
-    for (Value idx : indices)
-      if (!invariants.count(idx))
-        ++nonInvariant;
-    // Bail if more than one index varies for this single loop IV.
-    if (nonInvariant > 1) {
-      LLVM_DEBUG(dbgs() << "[early‑vect] Bail out: IV "
-                        << forOp.getInductionVar() << " drives " << nonInvariant
-                        << " indices\n");
-      return true;
+    for (Value idx : indices) {
+      if (invariants.count(idx))
+        continue;
+
+      if (++nonInvariant > 1) {
+        LLVM_DEBUG(dbgs() << "[early‑vect] Bail out: IV "
+                          << forOp.getInductionVar() << " drives "
+                          << nonInvariant << " indices\n");
+        return true;
+      }
     }
   }
   return false;

mlir/test/Dialect/Affine/SuperVectorize/vectorize_unsupported.mlir

@@ -33,10 +33,10 @@ func.func @iv_mapped_to_multiple_indices_unsupported(%arg0: index) -> memref<2x2
 // CHECK: #[[$ATTR_1:.+]] = affine_map<(d0)[s0] -> (d0 mod s0)>
 
 // CHECK-LABEL:   func.func @iv_mapped_to_multiple_indices_unsupported(
-// CHECK-SAME:      %[[VAL_0:[0-9]+|[a-zA-Z$._-][a-zA-Z0-9$._-]*]]: index) -> memref<2x2xf32> {
+// CHECK-SAME:      %[[VAL_0:.*]]: index) -> memref<2x2xf32> {
 // CHECK:           %[[VAL_1:.*]] = arith.constant 2 : index
 // CHECK:           affine.for %[[VAL_4:.*]] = 0 to 4 {
 // CHECK:             %[[VAL_5:.*]] = affine.apply #[[$ATTR_0]](%[[VAL_4]]){{\[}}%[[VAL_1]]]
 // CHECK:             %[[VAL_6:.*]] = affine.apply #[[$ATTR_1]](%[[VAL_4]]){{\[}}%[[VAL_1]]]
 // CHECK:           }
-// CHECK:         }
+// CHECK:         }