Skip to content

Commit 20bc6f2

Browse files
author
Debadri Basak
committed
Minor refactoring of the static functions
1 parent 5b478d1 commit 20bc6f2

File tree

2 files changed

+15
-12
lines changed

2 files changed

+15
-12
lines changed

clang/include/clang/Analysis/Analyses/LifetimeSafety/LifetimeSafety.h

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -80,19 +80,9 @@ class LifetimeSafetyAnalysis {
8080
LiveOriginsAnalysis &getLiveOrigins() const { return *LiveOrigins; }
8181
FactManager &getFactManager() { return FactMgr; }
8282

83-
static void PrintStats(llvm::raw_ostream &OS) {
84-
llvm::errs() << "\n*** LifetimeSafety Missing Origin Stats "
85-
"(expression_type : count) :\n";
86-
for (const auto &[expr, count] : LifetimeSafetyAnalysis::count) {
87-
OS << expr << " : " << count << '\n';
88-
}
89-
}
83+
static void PrintStats(llvm::raw_ostream &OS);
9084

91-
static void UpdateMissingOriginCount(const OriginManager &OM) {
92-
for (const auto &[expr, missing_origin_count] : OM.getMissingOrigins()) {
93-
LifetimeSafetyAnalysis::count[std::string(expr)] += missing_origin_count;
94-
}
95-
}
85+
static void UpdateMissingOriginCount(const OriginManager &OM);
9686

9787
private:
9888
AnalysisDeclContext &AC;

clang/lib/Analysis/LifetimeSafety/LifetimeSafety.cpp

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,19 @@ LifetimeSafetyAnalysis::LifetimeSafetyAnalysis(AnalysisDeclContext &AC,
3939
LifetimeSafetyReporter *Reporter)
4040
: AC(AC), Reporter(Reporter) {}
4141

42+
void LifetimeSafetyAnalysis::PrintStats(llvm::raw_ostream &OS) {
43+
llvm::errs() << "\n*** LifetimeSafety Missing Origin Stats "
44+
"(expression_type : count) :\n";
45+
for (const auto &[expr, count] : LifetimeSafetyAnalysis::MissingOriginCount) {
46+
OS << expr << " : " << count << '\n';
47+
}
48+
}
49+
50+
void LifetimeSafetyAnalysis::UpdateMissingOriginCount(const OriginManager &OM) {
51+
for (const auto &[expr, missing_origin_count] : OM.getMissingOrigins()) {
52+
LifetimeSafetyAnalysis::MissingOriginCount[std::string(expr)] += missing_origin_count;
53+
}
54+
}
4255
void LifetimeSafetyAnalysis::run() {
4356
llvm::TimeTraceScope TimeProfile("LifetimeSafetyAnalysis");
4457

0 commit comments

Comments
 (0)