Skip to content

Commit 214f1d7

Browse files
fixup! Address review comments
1 parent 48150d4 commit 214f1d7

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

lldb/include/lldb/Target/StopInfo.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ class StopInfo : public std::enable_shared_from_this<StopInfo> {
119119
StructuredData::ObjectSP GetExtendedInfo() { return m_extended_info; }
120120

121121
/// Returns true if this is a stop reason that should be shown to a user when
122-
/// stopping.
122+
/// viewing the thread with this stop info.
123123
virtual bool ShouldShow() const { return IsValid(); }
124124

125125
/// Returns true if this is a stop reason that should cause a thread to be

lldb/source/Target/StopInfo.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1139,8 +1139,7 @@ class StopInfoUnixSignal : public StopInfo {
11391139
std::optional<int> m_code;
11401140

11411141
bool IsShouldStopSignal() const {
1142-
ThreadSP thread_sp(m_thread_wp.lock());
1143-
if (thread_sp)
1142+
if (ThreadSP thread_sp = m_thread_wp.lock())
11441143
return thread_sp->GetProcess()->GetUnixSignals()->GetShouldStop(m_value);
11451144
return false;
11461145
}

0 commit comments

Comments
 (0)