Skip to content

Commit 21a6032

Browse files
authored
[MLIR][OpenMP] Simplify translation to LLVM IR error handling (#114036)
This patch unifies the handling of errors passed through the OpenMPIRBuilder and removes some redundant error messages through the introduction of a custom `ErrorInfo` subclass. Additionally, the current list of operations and clauses unsupported by the MLIR to LLVM IR translation pass is added to a new Lit test to check they are being reported to the user.
1 parent 262afc8 commit 21a6032

File tree

3 files changed

+625
-70
lines changed

3 files changed

+625
-70
lines changed

mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2499,13 +2499,7 @@ void OrderedRegionOp::build(OpBuilder &builder, OperationState &state,
24992499
OrderedRegionOp::build(builder, state, clauses.parLevelSimd);
25002500
}
25012501

2502-
LogicalResult OrderedRegionOp::verify() {
2503-
// TODO: The code generation for ordered simd directive is not supported yet.
2504-
if (getParLevelSimd())
2505-
return failure();
2506-
2507-
return verifyOrderedParent(**this);
2508-
}
2502+
LogicalResult OrderedRegionOp::verify() { return verifyOrderedParent(**this); }
25092503

25102504
//===----------------------------------------------------------------------===//
25112505
// TaskwaitOp

0 commit comments

Comments
 (0)