Skip to content

Commit 21b8e07

Browse files
committed
address review feedback
1 parent e526003 commit 21b8e07

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

llvm/utils/update_analyze_test_checks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,4 +229,4 @@ def main():
229229

230230

231231
if __name__ == "__main__":
232-
main()
232+
sys.exit(main())

llvm/utils/update_mca_test_checks.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -563,11 +563,13 @@ def update_test_file(args, test_path, autogenerated_note):
563563
)
564564

565565
def main():
566+
warnings.showwarning = _showwarning
566567
script_name = "utils/" + os.path.basename(__file__)
567568
parser = _get_parser()
568569
args = common.parse_commandline_args(parser)
569570
if not args.llvm_mca_binary:
570-
raise Error("--llvm-mca-binary value cannot be empty string")
571+
stderr.write("Error: --llvm-mca-binary value cannot be empty string\n")
572+
return 1
571573

572574
if "llvm-mca" not in os.path.basename(args.llvm_mca_binary):
573575
_warn("unexpected binary name: {}".format(args.llvm_mca_binary))
@@ -584,9 +586,4 @@ def main():
584586

585587

586588
if __name__ == "__main__":
587-
try:
588-
warnings.showwarning = _showwarning
589-
sys.exit(main())
590-
except Error as e:
591-
sys.stdout.write("error: {}\n".format(e))
592-
sys.exit(1)
589+
sys.exit(main())

0 commit comments

Comments
 (0)