cache begin in callexpr

Author: cor3ntin

clang/include/clang/AST/Expr.h

@@ -3202,6 +3202,12 @@ class CallExpr : public Expr {
   void setRParenLoc(SourceLocation L) { RParenLoc = L; }
 
   SourceLocation getBeginLoc() const {
+    if(CallExprBits.HasTrailingSourceLoc) {
+        static_assert(sizeof(CallExpr) <= offsetToTrailingObjects + 2 * sizeof(SourceLocation));
+        return *reinterpret_cast<const SourceLocation*>(reinterpret_cast<const char *>(this) +
+                                                        sizeof(CallExpr));
+    }
+
     //if (const auto *OCE = dyn_cast<CXXOperatorCallExpr>(this))
     //    return OCE->getBeginLoc();
 
@@ -3223,6 +3229,23 @@ class CallExpr : public Expr {
 
   SourceLocation getEndLoc() const LLVM_READONLY;
 
+private:
+  friend class ASTStmtReader;
+  bool hasTrailingSourceLoc() const {
+      return CallExprBits.HasTrailingSourceLoc;
+  }
+  void setTrailingSourceLocs() {
+      assert(!CallExprBits.HasTrailingSourceLoc);
+      static_assert(sizeof(CallExpr) <= offsetToTrailingObjects + 2 * sizeof(SourceLocation));
+      SourceLocation* Locs = reinterpret_cast<SourceLocation*>(reinterpret_cast<char *>(this) +
+                                                               sizeof(CallExpr));
+      Locs[0] = getBeginLoc();
+      Locs[1] = getEndLoc();
+      CallExprBits.HasTrailingSourceLoc = true;
+  }
+
+public:
+
   /// Return true if this is a call to __assume() or __builtin_assume() with
   /// a non-value-dependent constant parameter evaluating as false.
   bool isBuiltinAssumeFalse(const ASTContext &Ctx) const;

clang/include/clang/AST/Stmt.h

@@ -568,9 +568,12 @@ class alignas(void *) Stmt {
 
     LLVM_PREFERRED_TYPE(bool)
     unsigned ExplicitObjectMemFunUsingMemberSyntax : 1;
+
+    LLVM_PREFERRED_TYPE(bool)
+    unsigned HasTrailingSourceLoc : 1;
   };
 
-  enum { NumCallExprBits = 24 };
+  enum { NumCallExprBits = 25 };
 
   class MemberExprBitfields {
     friend class ASTStmtReader;

clang/lib/AST/Expr.cpp

@@ -1475,6 +1475,7 @@ CallExpr::CallExpr(StmtClass SC, Expr *Fn, ArrayRef<Expr *> PreArgs,
   CallExprBits.HasFPFeatures = FPFeatures.requiresTrailingStorage();
   CallExprBits.IsCoroElideSafe = false;
   CallExprBits.ExplicitObjectMemFunUsingMemberSyntax = false;
+  CallExprBits.HasTrailingSourceLoc = false;
 
   if (hasStoredFPFeatures())
     setStoredFPFeatures(FPFeatures);
@@ -1487,6 +1488,9 @@ CallExpr::CallExpr(StmtClass SC, unsigned NumPreArgs, unsigned NumArgs,
   assert((NumPreArgs == getNumPreArgs()) && "NumPreArgs overflow!");
   CallExprBits.HasFPFeatures = HasFPFeatures;
   CallExprBits.IsCoroElideSafe = false;
+  CallExprBits.ExplicitObjectMemFunUsingMemberSyntax = false;
+  CallExprBits.HasTrailingSourceLoc = false;
+
 }
 
 CallExpr *CallExpr::Create(const ASTContext &Ctx, Expr *Fn,
@@ -1500,8 +1504,10 @@ CallExpr *CallExpr::Create(const ASTContext &Ctx, Expr *Fn,
   void *Mem =
       Ctx.Allocate(sizeToAllocateForCallExprSubclass<CallExpr>(SizeOfTrailingObjects),
                    alignof(CallExpr));
-  return new (Mem) CallExpr(CallExprClass, Fn, /*PreArgs=*/{}, Args, Ty, VK,
+  CallExpr* E = new (Mem) CallExpr(CallExprClass, Fn, /*PreArgs=*/{}, Args, Ty, VK,
                             RParenLoc, FPFeatures, MinNumArgs, UsesADL);
+  E->setTrailingSourceLocs();
+  return E;
 }
 
 CallExpr *CallExpr::CreateEmpty(const ASTContext &Ctx, unsigned NumArgs,

clang/lib/Serialization/ASTReaderStmt.cpp

@@ -1047,6 +1047,9 @@ void ASTStmtReader::VisitCallExpr(CallExpr *E) {
   if (HasFPFeatures)
     E->setStoredFPFeatures(
         FPOptionsOverride::getFromOpaqueInt(Record.readInt()));
+
+  if(E->getStmtClass() == Stmt::CallExprClass)
+    E->setTrailingSourceLocs();
 }
 
 void ASTStmtReader::VisitCXXMemberCallExpr(CXXMemberCallExpr *E) {