Address review

Author: bcardosolopes

mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td

@@ -1302,8 +1302,8 @@ def ModuleFlagAttr
     Represents a single entry of llvm.module.flags metadata
     (llvm::Module::ModuleFlagEntry in LLVM). The first element is a behavior
     flag described by `ModFlagBehaviorAttr`, the second is a string ID
-    and third is the value of the flag (currently only integer constant
-    supported).
+    and third is the value of the flag (currently only integer constants
+    are supported).
 
     Example:
     ```mlir

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

@@ -3720,10 +3720,9 @@ LogicalResult ModuleFlagsOp::verify() {
   if (Operation *parentOp = (*this)->getParentOp();
       parentOp && !satisfiesLLVMModule(parentOp))
     return emitOpError("must appear at the module level");
-  for (Attribute flag : getFlags()) {
+  for (Attribute flag : getFlags())
     if (!isa<ModuleFlagAttr>(flag))
       return emitOpError("expected a module flag attribute");
-  }
   return success();
 }
 

mlir/lib/Target/LLVMIR/ModuleImport.cpp

@@ -518,15 +518,10 @@ void ModuleImport::addDebugIntrinsic(llvm::CallInst *intrinsic) {
 }
 
 LogicalResult ModuleImport::convertModuleFlagsMetadata() {
-  SmallVector<llvm::Module::ModuleFlagEntry, 4> llvmModuleFlags;
-  for (const llvm::NamedMDNode &named : llvmModule->named_metadata()) {
-    if (named.getName() != LLVMDialect::getModuleFlags())
-      continue;
-    llvmModule->getModuleFlagsMetadata(llvmModuleFlags);
-    break; // there can only be one module flags.
-  }
+  SmallVector<llvm::Module::ModuleFlagEntry> llvmModuleFlags;
+  llvmModule->getModuleFlagsMetadata(llvmModuleFlags);
 
-  SmallVector<Attribute, 4> moduleFlags;
+  SmallVector<Attribute> moduleFlags;
   for (const auto [behavior, key, val] : llvmModuleFlags) {
     // Currently only supports most common: int constant values.
     auto *constInt = llvm::mdconst::dyn_extract<llvm::ConstantInt>(val);

mlir/test/Target/LLVMIR/llvmir.mlir

@@ -2774,11 +2774,11 @@ module {
                      #llvm.mlir.module_flag<max, "frame-pointer", 1>]
 }
 
-// CHECK: !llvm.module.flags = !{![[#DBG:]], ![[#WCHAR:]], ![[#PIC:]], ![[#PIE:]], ![[#UWTABLE:]], ![[#FP:]]}
+// CHECK: !llvm.module.flags = !{![[#DBG:]], ![[#WCHAR:]], ![[#PIC:]], ![[#PIE:]], ![[#UWTABLE:]], ![[#FrameP:]]}
 
 // CHECK: ![[#DBG]] = !{i32 2, !"Debug Info Version", i32 3}
 // CHECK: ![[#WCHAR]] = !{i32 1, !"wchar_size", i32 4}
 // CHECK: ![[#PIC]] = !{i32 8, !"PIC Level", i32 2}
 // CHECK: ![[#PIE]] = !{i32 7, !"PIE Level", i32 2}
 // CHECK: ![[#UWTABLE]] = !{i32 7, !"uwtable", i32 2}
-// CHECK: ![[#FP]] = !{i32 7, !"frame-pointer", i32 1}
+// CHECK: ![[#FrameP]] = !{i32 7, !"frame-pointer", i32 1}