Updates based on PR review feedback

Author: llvm-beanz

clang/lib/AST/DeclCXX.cpp

@@ -1464,7 +1464,11 @@ void CXXRecordDecl::addedMember(Decl *D) {
   }
 
   // HLSL: All user-defined data types are aggregates and use aggregate
-  // initialization. This _needs_ to change in the future. There are two
+  // initialization, meanwhile most, but not all built-in types behave like
+  // aggregates. Resource types, and some other HLSL types that wrap handles
+  // don't behave like aggregates. We can identify these as different because we
+  // implicitly define "special" member functions, which aren't spellable in
+  // HLSL. This all _needs_ to change in the future. There are two
   // relevant HLSL feature proposals that will depend on this changing:
   // * 0005-strict-initializer-lists.md
   // * https://github.com/microsoft/hlsl-specs/pull/325

clang/lib/CodeGen/CGExprAgg.cpp

@@ -1782,7 +1782,9 @@ void AggExprEmitter::VisitCXXParenListOrInitListExpr(
   // emit these we need to emit the opaque values before we emit the argument
   // expressions themselves. This is a little hacky, but it prevents us needing
   // to do a bigger AST-level change for a language feature that we need
-  // deprecate in the near future.
+  // deprecate in the near future. See related HLSL language proposals:
+  // * 0005-strict-initializer-lists.md
+  // * https://github.com/microsoft/hlsl-specs/pull/325
   if (CGF.getLangOpts().HLSL && isa<InitListExpr>(ExprToVisit))
     CGF.CGM.getHLSLRuntime().emitInitListOpaqueValues(
         CGF, cast<InitListExpr>(ExprToVisit));

clang/lib/Sema/SemaHLSL.cpp

@@ -3096,8 +3096,8 @@ static bool BuildInitializerList(Sema &S, ASTContext &Ctx, Expr *E,
   if (Ty->isScalarType() || (Ty->isRecordType() && !Ty->isAggregateType()))
     return CastInitializer(S, Ctx, E, List, DestTypes);
 
-  if (auto *ATy = Ty->getAs<VectorType>()) {
-    uint64_t Size = ATy->getNumElements();
+  if (auto *VecTy = Ty->getAs<VectorType>()) {
+    uint64_t Size = VecTy->getNumElements();
 
     QualType SizeTy = Ctx.getSizeType();
     uint64_t SizeTySize = Ctx.getTypeSize(SizeTy);
@@ -3115,8 +3115,8 @@ static bool BuildInitializerList(Sema &S, ASTContext &Ctx, Expr *E,
     return true;
   }
 
-  if (auto *VTy = dyn_cast<ConstantArrayType>(Ty.getTypePtr())) {
-    uint64_t Size = VTy->getZExtSize();
+  if (auto *ArrTy = dyn_cast<ConstantArrayType>(Ty.getTypePtr())) {
+    uint64_t Size = ArrTy->getZExtSize();
     QualType SizeTy = Ctx.getSizeType();
     uint64_t SizeTySize = Ctx.getTypeSize(SizeTy);
     for (uint64_t I = 0; I < Size; ++I) {