Skip to content

Commit 23537b5

Browse files
Joao SaffranJoao Saffran
authored andcommitted
addressing comment
1 parent 8a4ee3c commit 23537b5

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

llvm/include/llvm/Frontend/HLSL/RootSignatureMetadata.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,10 @@ class TableRegisterOverflowError
9393
: Type(Type), Register(Register), Space(Space) {}
9494

9595
void log(raw_ostream &OS) const override {
96-
OS << "Cannot bind resource of type "
96+
OS << "Cannot append range with implicit lower bound after an unbounded "
97+
"range "
9798
<< getResourceClassName(toResourceClass(Type))
98-
<< "(register=" << Register << ", space=" << Space
99-
<< "), it exceeds the maximum allowed register value.";
99+
<< "(register=" << Register << ", space=" << Space << ").";
100100
}
101101

102102
std::error_code convertToErrorCode() const override {

llvm/test/CodeGen/DirectX/rootsignature-validation-fail-appending-overflow.ll

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
; RUN: not opt -S -passes='dxil-post-optimization-validation' -mtriple=dxil-pc-shadermodel6.6-compute %s 2>&1 | FileCheck %s
22
; This test check if a resource is implicitly overflowing. That means, it is appending a resource after an unbounded range.
33

4-
; CHECK: error: Cannot bind resource of type UAV(register=0, space=0), it exceeds the maximum allowed register value.
4+
; CHECK: error: Cannot append range with implicit lower bound after an unbounded range UAV(register=0, space=0).
55

66
@TB.str = private unnamed_addr constant [3 x i8] c"TB\00", align 1
77

@@ -17,5 +17,3 @@ entry:
1717
!3 = !{!"DescriptorTable", i32 0, !4, !5}
1818
!4 = !{!"UAV", i32 -1, i32 1, i32 0, i32 2, i32 0}
1919
!5 = !{!"UAV", i32 1, i32 0, i32 0, i32 -1, i32 0}
20-
21-

llvm/test/CodeGen/DirectX/rootsignature-validation-fail-register-overflow.ll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
; RUN: not opt -S -passes='dxil-post-optimization-validation' -mtriple=dxil-pc-shadermodel6.6-compute %s 2>&1 | FileCheck %s
2-
; CHECK: error: Cannot bind resource of type UAV(register=4294967295, space=0), it exceeds the maximum allowed register value.
2+
; CHECK: error: Cannot append range with implicit lower bound after an unbounded range UAV(register=4294967295, space=0).
33
@TB.str = private unnamed_addr constant [3 x i8] c"TB\00", align 1
44

55
define void @CSMain() "hlsl.shader"="compute" {
@@ -13,4 +13,3 @@ entry:
1313
!1 = !{!3}
1414
!3 = !{!"DescriptorTable", i32 0, !4}
1515
!4 = !{!"UAV", i32 100, i32 4294967295, i32 0, i32 -1, i32 0}
16-

0 commit comments

Comments
 (0)