Skip to content

Commit 2365109

Browse files
committed
workflows/release-binaries: Stop using ccache
Using ccache is a potential security risk, because the GitHub Actions cache is writable by pull requests, which means that any GitHub user could upload malicious data to the cache.
1 parent 5cb2db3 commit 2365109

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

.github/workflows/release-binaries.yml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -216,14 +216,6 @@ jobs:
216216
id: setup-stage
217217
uses: ./workflows-main/.github/workflows/release-binaries-setup-stage
218218

219-
- name: Setup sccache
220-
uses: hendrikmuhs/ccache-action@ca3acd2731eef11f1572ccb126356c2f9298d35e # v1.2.9
221-
with:
222-
# Default to 2G to workaround: https://github.com/hendrikmuhs/ccache-action/issues/174
223-
max-size: 2G
224-
key: sccache-${{ runner.os }}-${{ runner.arch }}-release
225-
variant: sccache
226-
227219
- name: Configure
228220
id: build
229221
shell: bash
@@ -234,9 +226,7 @@ jobs:
234226
${{ needs.prepare.outputs.target-cmake-flags }} \
235227
-C clang/cmake/caches/Release.cmake \
236228
-DBOOTSTRAP_LLVM_PARALLEL_LINK_JOBS=1 \
237-
-DBOOTSTRAP_CPACK_PACKAGE_FILE_NAME="${{ needs.prepare.outputs.release-binary-basename }}" \
238-
-DCMAKE_C_COMPILER_LAUNCHER=sccache \
239-
-DCMAKE_CXX_COMPILER_LAUNCHER=sccache
229+
-DBOOTSTRAP_CPACK_PACKAGE_FILE_NAME="${{ needs.prepare.outputs.release-binary-basename }}"
240230
- name: Build
241231
shell: bash
242232
run: |

0 commit comments

Comments
 (0)