Make code more recursive, add tests

Author: spavloff

clang/lib/Sema/AnalysisBasedWarnings.cpp

@@ -469,20 +469,18 @@ struct TransferFunctions : public StmtVisitor<TransferFunctions> {
   }
 
   void VisitCXXOperatorCallExpr(CXXOperatorCallExpr *CE) {
-    if (CE->getOperator() == OO_Call && CE->getNumArgs() > 0) {
-      Expr *Obj = CE->getArg(0)->IgnoreParenCasts();
-      if (auto *MTE = dyn_cast<MaterializeTemporaryExpr>(Obj))
-        Obj = MTE->getSubExpr();
-      if (auto *DRE = dyn_cast<DeclRefExpr>(Obj)) {
-        auto *D = dyn_cast<VarDecl>(DRE->getDecl());
-        if (D && D->hasInit())
-          Obj = D->getInit();
-      }
-      Visit(Obj);
-    }
+    if (CE->getOperator() == OO_Call && CE->getNumArgs() > 0)
+      Visit(CE->getArg(0)->IgnoreParenCasts());
     VisitCallExpr(CE);
   }
 
+  void VisitDeclRefExpr(DeclRefExpr *DRef) {
+    if (auto *D = dyn_cast<VarDecl>(DRef->getDecl())) {
+      if (D->hasInit())
+        Visit(D->getInit());
+    }
+  }
+
   void VisitLambdaExpr(LambdaExpr *LE) {
     for (const LambdaCapture &Capture : LE->captures())
       if (Capture.capturesVariable())

clang/test/SemaCXX/noreturn-vars.cpp

@@ -272,3 +272,27 @@ extern void abc_02(func_type *);
   LF(func_ptr);
   func_ptr();
 }
+
+[[noreturn]] void call_lambda_by_ptr(int x) {
+  func_type func_ptr = noret;
+  auto LF = [&func_ptr](){};
+  auto LFPtr = &LF;
+  (*LFPtr)();
+  func_ptr();
+} // expected-warning {{function declared 'noreturn' should not return}}
+
+[[noreturn]] void call_lambda_by_ptr_no_capture(int x) {
+  func_type func_ptr = noret;
+  auto LF = [](){};
+  auto LFPtr = &LF;
+  (*LFPtr)();
+  func_ptr();
+}
+
+[[noreturn]] void call_lambda_by_ptr_capture_value(int x) {
+  func_type func_ptr = noret;
+  auto LF = [func_ptr](){};
+  auto LFPtr = &LF;
+  (*LFPtr)();
+  func_ptr();
+}